Skip to content

[WIP] Disable metrics export if the number of mounts in a pod is more than 20#1122

Draft
kislaykishore wants to merge 1 commit intomainfrom
limit-metrics
Draft

[WIP] Disable metrics export if the number of mounts in a pod is more than 20#1122
kislaykishore wants to merge 1 commit intomainfrom
limit-metrics

Conversation

@kislaykishore
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:
A single GCSFuse pod can support several GCSFuse mounts. This can can cause the GCSFuse metrics cardinality to blow up without an cap. This PR puts the cap on it by disabling metrics collection if the number of GCSFuse mounts exceeds 20.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
Yes

Metrics collection will be disabled if the number of mounts in a single pod exceeds 20.

@google-oss-prow
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow
Copy link
Copy Markdown

@kislaykishore: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

Details

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:
A single GCSFuse pod can support several GCSFuse mounts. This can can cause the GCSFuse metrics cardinality to blow up without an cap. This PR puts the cap on it by disabling metrics collection if the number of GCSFuse mounts exceeds 20.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
Yes

Metrics collection will be disabled if the number of mounts in a single pod exceeds 20.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kislaykishore

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant