Relese GCSFuse v3.8.0 in CSI driver#1264
Relese GCSFuse v3.8.0 in CSI driver#1264uriel-guzman merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on simplifying the cache recommendation logic by completely deprecating and removing the metadata type cache. This change streamlines the codebase, reduces complexity, and ensures that the system only manages relevant caching mechanisms. Additionally, Go workspace files have been introduced, which will facilitate better module management and development practices. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
13180cd to
ce6f48e
Compare
There was a problem hiding this comment.
Code Review
This pull request effectively deprecates and removes the 'type cache' feature from the GCS FUSE recommender. The changes are comprehensive, touching the core logic, tests, and E2E tests to remove all traces of the type cache. The removal of the overridableCalc struct and related logic in recommendCacheConfigs simplifies the code for cache size calculation significantly, which is a great improvement for maintainability. The test suite has been thoroughly updated to reflect these changes. Overall, the changes are solid, with one minor suggestion for improving code clarity.
ce6f48e to
ab23c0c
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request effectively deprecates and removes the 'type cache' from the GKE GCSFuse Profiles feature, aligning with its upcoming deprecation in GCSFuse v3.8.0. The changes are consistently applied across the recommender logic, unit tests, and E2E tests. The removal of the type cache logic has also led to a welcome simplification of the codebase, particularly in how cache size recommendations and overrides are handled. The changes are correct and improve the maintainability of the code. I have one minor suggestion to improve a test's error message for consistency.
36367ad to
a5b4ceb
Compare
a5b4ceb to
6bb7f6d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amacaskill, uriel-guzman The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6bb7f6d to
5cc063b
Compare
|
New changes are detected. LGTM label has been removed. |
…1264-upstream-release-1.22 Automated cherry pick of #1264: Relese GCSFuse v3.8.0 in CSI driver
What type of PR is this?
/kind feature
What this PR does / why we need it:
Release GCSFuse v3.8.0 in the CSI driver.
GCSFuse deprecated type cache and merge it to stat cache in v3.8.0, so we should stop calculating this recommendation in profiles.
Flat buckets increase their upper bound for average stat cache per file from 1500 to 1700 bytes (because it merged with type cache), so a new HNS annotation has been added in order to make this differentiation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Manual verification
Flat bucket
PV scanned successfully with correct annotations:
Recommendation:
HNS bucket
PV scan successful
Recommendation log:
Does this PR introduce a user-facing change?: