Add e2e tests for OIDC authentication failures with misconfigured and non-existent WIF providers#1322
Conversation
|
@su-sudhir: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @su-sudhir. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Code Review
This pull request introduces new E2E test cases to verify authentication failures in the GCS Fuse CSI driver when using misconfigured or non-existent OIDC workload identity providers and pools. The feedback suggests an improvement to test efficiency by removing redundant bucket access configuration and sleep intervals in negative test cases where authentication is expected to fail before any bucket interaction occurs.
|
/ok-to-test |
mattcary
left a comment
There was a problem hiding this comment.
looks good, but waiting on dependent PR (the one that sets the oss env vars, etc)
|
Just waiting on the CLA to be resolved for this one. |
|
Manual testing for this testcase On OSS: |
adc3199 to
c432a47
Compare
|
Resolved the conflicts and reran the tests. Logs |
mattcary
left a comment
There was a problem hiding this comment.
Need to update gofmt (run hack/verify-all.sh to check that kind of thing)
c432a47 to
acfbd3f
Compare
… non-existent WIF providers
… panic on OSS clusters
acfbd3f to
d6bfb4a
Compare
Formatting for the PR is done and It's ready to be merged. Thanks! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mattcary, su-sudhir The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Revert "Merge pull request #1322 from su-sudhir/add-oidc-auth-failure-e2e-tests
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds two negative e2e test cases to the existing
oidctest suite to validate STS-level authentication failures for Workload Identity Federation:issclaim and the gcsfuse sidecar logs"Error connecting to the given credential's issuer."invalid_targetand the sidecar logs it accordingly.Both tests use
SkipCSIBucketAccessCheckPrefixso the failure surface is entirely inside the gcsfuse sidecar, not the CSI node driver pre-flight check.Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: