Allow multiple volume handles/mount options for same bucket#558
Closed
chrisThePattyEater wants to merge 0 commit intoGoogleCloudPlatform:mainfrom
Closed
Allow multiple volume handles/mount options for same bucket#558chrisThePattyEater wants to merge 0 commit intoGoogleCloudPlatform:mainfrom
chrisThePattyEater wants to merge 0 commit intoGoogleCloudPlatform:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Recently, a customer tried mounting the same GCS bucket with different mount options but their pod got stuck initializing: b/394408963. This is not supported.
This pr allows multiple volume handles/mount options for same bucket by allowing users to provide a suffix :suffix which will be stripped during node publish volume but allows the webhook to treat the two as separate buckets
Which issue(s) this PR fixes:
Fixes #395976718
Does this PR introduce a user-facing change?:
How was this tested/validated:
mounted two volumes to one container with two different mount options using custom built image and verified sidecar containers are running
containers:
- name: gcsfuse-container-1
image: google/cloud-sdk:alpine
command:
- "sleep"
- "3600"
volumeMounts:
- name: gcsfuse-volume-1
mountPath: /mnt/gcsfuse-1
subPath: gcsfuse-mount
- name: gcsfuse-volume-2
mountPath: /mnt/gcsfuse-2
subPath: gcsfuse-mount
volumes:
- name: gcsfuse-volume-1
csi:
driver: "gcsfuse.csi.storage.gke.io"
volumeAttributes:
bucketName: "fuechr_fuse_csi_test:1"
skipCSIBucketAccessCheck: "false"
- name: gcsfuse-volume-2
csi:
driver: "gcsfuse.csi.storage.gke.io"
volumeAttributes:
bucketName: "fuechr_fuse_csi_test:2"
skipCSIBucketAccessCheck: "true"