Skip to content

Conversation

@kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Dec 26, 2025

Description

Add make targets for running integration tests. This allows one to execute make integ-test to run integration tests

Link to the issue in case of a bug fix.

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

No

@kislaykishore kislaykishore requested review from a team, Tulsishah and meet2mky as code owners December 26, 2025 06:02
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Dec 26, 2025
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.08%. Comparing base (8985dad) to head (026551e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4207      +/-   ##
==========================================
- Coverage   83.09%   83.08%   -0.02%     
==========================================
  Files         154      154              
  Lines       18980    18980              
==========================================
- Hits        15772    15770       -2     
- Misses       2631     2633       +2     
  Partials      577      577              
Flag Coverage Δ
unittests 83.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Hi @meet2mky, @Tulsishah, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

2 similar comments
@github-actions
Copy link

Hi @meet2mky, @Tulsishah, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

Hi @meet2mky, @Tulsishah, @charith87, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

charith87
charith87 previously approved these changes Dec 31, 2025
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

2 similar comments
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Hi @meet2mky, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@meet2mky
Copy link
Collaborator

meet2mky commented Jan 5, 2026

@kislaykishore description still says unit tests but it seems you removed it?

Is running integ_test with only regional expected?

Copy link
Collaborator

@meet2mky meet2mky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@kislaykishore kislaykishore changed the title ci(build): Add make targets for running integration and unit tests ci(build): Add make targets for running integration tests Jan 7, 2026
@kislaykishore kislaykishore force-pushed the make-test branch 2 times, most recently from fa3c3dd to d046b1f Compare January 7, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants