-
Notifications
You must be signed in to change notification settings - Fork 472
fix(integration-tests): Support Non Debian/Ubuntu based Machines for executing improved_e2e integration tests #4225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… integration test script
|
Hi @meet2mky, @Tulsishah, @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
1 similar comment
|
Hi @meet2mky, @Tulsishah, @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
44b563e to
17a7c27
Compare
bed0d56 to
107c15c
Compare
107c15c to
a4c0358
Compare
fcee446 to
34173f2
Compare
34173f2 to
2701ba0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4225 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good! have added e2e labels for running tests on kokoro. |
Tulsishah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relying on @meet2mky's approval.
Description
Issue: Integration Scripts Incompatible with RHEL Environments
1. Error in
improved_run_e2e_tests.shThe script failed because it relies on
apt-get, which is specific to Debian/Ubuntu systems.2. Error in
./perfmetrics/scripts/install_go.shThe Go installer failed because it used
dpkgto determine the system architecture, causing the installation to be skipped on non-Debian distributions.Solution
To support multiple Linux distributions (RHEL, Debian, etc.), the scripts were updated to be distro-agnostic:
system_arch=$(uname -m)to detect the architecture without relying on package managers./etc/os-releaseto dynamically select the correct package manager (apt-get,yum, etc.):Created a new centralized script perfmetrics/scripts/os_utils.sh to handle OS and architecture detection as well as package installation logic.
Link to the issue in case of a bug fix. https://buganizer.corp.google.com/issues/473274511
Testing details
Any backward incompatible change? If so, please explain.