Skip to content

Conversation

@PranjalC100
Copy link
Member

@PranjalC100 PranjalC100 commented Dec 31, 2025

Description

Issue: Integration Scripts Incompatible with RHEL Environments

1. Error in improved_run_e2e_tests.sh
The script failed because it relies on apt-get, which is specific to Debian/Ubuntu systems.

2. Error in ./perfmetrics/scripts/install_go.sh
The Go installer failed because it used dpkg to determine the system architecture, causing the installation to be skipped on non-Debian distributions.

Solution

To support multiple Linux distributions (RHEL, Debian, etc.), the scripts were updated to be distro-agnostic:

  • Architecture Detection: Switched to system_arch=$(uname -m) to detect the architecture without relying on package managers.
  • OS Detection: Implemented a check using /etc/os-release to dynamically select the correct package manager (apt-get, yum, etc.):
    if [ -f /etc/os-release ]; then
        . /etc/os-release
        # Execute install commands based on $ID

Created a new centralized script perfmetrics/scripts/os_utils.sh to handle OS and architecture detection as well as package installation logic.

Link to the issue in case of a bug fix. https://buganizer.corp.google.com/issues/473274511

Testing details

  1. Manual - Ran the new Manual CD script in gcsfuse-tools to test on a rhel based machine. The run was successful, logs at http://shortn/_iakOVsppDv

Any backward incompatible change? If so, please explain.

@PranjalC100 PranjalC100 requested a review from meet2mky December 31, 2025 10:00
@PranjalC100 PranjalC100 requested review from a team and Tulsishah as code owners December 31, 2025 10:00
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Dec 31, 2025
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Hi @meet2mky, @Tulsishah, @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Hi @meet2mky, @Tulsishah, @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@PranjalC100 PranjalC100 force-pushed the rhel-compatible-improved-e2e-test-script branch 2 times, most recently from 44b563e to 17a7c27 Compare January 5, 2026 11:47
@PranjalC100 PranjalC100 force-pushed the rhel-compatible-improved-e2e-test-script branch 4 times, most recently from bed0d56 to 107c15c Compare January 5, 2026 16:29
@PranjalC100 PranjalC100 force-pushed the rhel-compatible-improved-e2e-test-script branch from 107c15c to a4c0358 Compare January 5, 2026 16:32
@PranjalC100 PranjalC100 enabled auto-merge (squash) January 6, 2026 06:42
@PranjalC100 PranjalC100 requested a review from meet2mky January 6, 2026 06:42
@PranjalC100 PranjalC100 force-pushed the rhel-compatible-improved-e2e-test-script branch from fcee446 to 34173f2 Compare January 6, 2026 10:08
@PranjalC100 PranjalC100 force-pushed the rhel-compatible-improved-e2e-test-script branch from 34173f2 to 2701ba0 Compare January 6, 2026 10:15
@meet2mky meet2mky added execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. labels Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (81fedfe) to head (6b1a435).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff       @@
##   master   #4225   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meet2mky
Copy link
Collaborator

meet2mky commented Jan 6, 2026

Looks good! have added e2e labels for running tests on kokoro.

Copy link
Collaborator

@Tulsishah Tulsishah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying on @meet2mky's approval.

@PranjalC100 PranjalC100 merged commit d10f9d3 into master Jan 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants