Skip to content

Conversation

@abhishek10004
Copy link
Collaborator

Description

This pull request introduces a new 'MRD Simple Reader' for zonal buckets, enabled by a new enable-kernel-reader flag. This involves adding a new read path in the filesystem logic, and several new components like MrdInstance and MrdSimpleReader to manage multi-range downloads. The changes are extensive and include new logic for caching and lifecycle management of downloader instances, along with comprehensive tests.

Link to the issue in case of a bug fix.

b/472227021

Testing details

  1. Manual - Done
  2. Unit tests - Done
  3. Integration tests - Will be part of a separate PR

Any backward incompatible change? If so, please explain.

@abhishek10004 abhishek10004 added execute-perf-test Execute performance test in PR execute-integration-tests-on-zb To run E2E tests on zonal bucket. labels Jan 2, 2026
@abhishek10004 abhishek10004 marked this pull request as ready for review January 2, 2026 11:36
@abhishek10004 abhishek10004 requested a review from a team as a code owner January 2, 2026 11:36
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Jan 2, 2026
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

/gemini review

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

/gemini summary

@abhishek10004 abhishek10004 requested review from raj-prince and vadlakondaswetha and removed request for ashmeenkaur January 2, 2026 11:37
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 79.34783% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.05%. Comparing base (3d0a0b9) to head (0835d22).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
internal/gcsx/mrd_instance.go 83.72% 12 Missing and 9 partials ⚠️
internal/fs/fs.go 0.00% 6 Missing and 1 partial ⚠️
internal/gcsx/mrd_pool.go 22.22% 6 Missing and 1 partial ⚠️
internal/fs/handle/file.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4234      +/-   ##
==========================================
- Coverage   83.10%   83.05%   -0.06%     
==========================================
  Files         154      156       +2     
  Lines       18915    19157     +242     
==========================================
+ Hits        15720    15911     +191     
- Misses       2622     2653      +31     
- Partials      573      593      +20     
Flag Coverage Δ
unittests 83.05% <79.34%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raj-prince raj-prince self-requested a review January 7, 2026 10:23
raj-prince
raj-prince previously approved these changes Jan 7, 2026
@abhishek10004 abhishek10004 removed execute-perf-test Execute performance test in PR execute-integration-tests-on-zb To run E2E tests on zonal bucket. labels Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants