test(flag_optimizations): Add e2e tests for zonal bucket optimizations

[vipnydav]

Description

This PR adds integration tests to verify the automatic optimizations applied for zonal buckets in GCSFuse.

Link to the issue in case of a bug fix.

b/477834782

Testing details

1. Manual - Done
2. Unit tests - NA
3. Integration tests - Automated

Any backward incompatible change? If so, please explain.

[gemini-code-assist]

Summary of Changes

Hello @vipnydav, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive integration tests to validate the automatic optimizations applied by GCSFuse for zonal buckets. These tests ensure that the correct configuration values are logged and that the expected kernel parameters are set, thereby confirming the proper functioning of the zonal bucket optimization feature.

Highlights

• New Integration Tests: Added end-to-end tests to verify automatic optimizations applied for zonal buckets in GCSFuse.
• Configuration Verification: Introduced a helper function validateConfigValues to parse GCSFuse logs and assert that expected configuration settings are applied.
• Kernel Parameter Validation: Included tests to directly verify kernel parameters (like read_ahead_kb, max_background, congestion_threshold) are correctly set in /sys for zonal buckets.
• API Visibility: The pathForParam function in internal/kernelparams was made public (PathForParam) to allow access from the new integration tests.
• Mounting Flag Adjustment: Removed the hardcoded --enable-kernel-reader=false flag from various mounting utilities to enable proper testing of kernel reader optimizations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces comprehensive integration tests to verify the automatic optimizations applied for zonal buckets in GCSFuse. The changes include exporting the PathForParam function, adding new test cases to validate both logged configuration values and actual kernel parameters, and adjusting mounting utilities to allow the optimization logic to control the enable-kernel-reader flag. The new tests are well-structured and enhance the test coverage for this feature. Additionally, please ensure consistency between manual test configurations and test_config.yaml to prevent unexpected test behavior, specifically regarding the --enable-kernel-reader=true flag.

[github-actions]

Hi @abhishek10004, @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.45%. Comparing base (93da22d) to head (5cb5f56).
⚠️ Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/kernelparams/kernelparams.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
+ Coverage   83.39%   83.45%   +0.06%     
==========================================
  Files         162      162              
  Lines       19435    19440       +5     
==========================================
+ Hits        16208    16224      +16     
+ Misses       2626     2617       -9     
+ Partials      601      599       -2     

Flag	Coverage Δ
unittests	83.45% <50.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Hi @Tulsishah, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!