-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add example for MultiKueue w/ ClusterProfile #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@zhang-xuebin @knee-berts @mimowo I'm sharing an e2e example for MultiKueue with ClusterProfile and GKE Fleet. I use Terraform to simplify the steps. PTAL. |
kshalot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together, I think this looks good! But the ClusterQueue API comment should be addressed. I went through the setup manually and it works, I can't vouch for the Terraforms, but they look sensible to me.
JFYI We are likely going to link back to this document as the "how-to set up MultiKueue ClusterProfile on GKE" from the Kueue docs.
Sounds great! This is relevant to kubernetes-sigs/kueue#7873 cc @mimowo |
kshalot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one nitty suggestion. Other than that, LGTM 👍
zhang-xuebin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the flow and LGTM, thanks for putting these together!
fae0c3a to
2f9f4a7
Compare
2f9f4a7 to
d6df696
Compare
No description provided.