Skip to content

Add get_metric_schema for GKE resource schemas#136

Draft
erain wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
erain:feat/get-metric-schema
Draft

Add get_metric_schema for GKE resource schemas#136
erain wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
erain:feat/get-metric-schema

Conversation

@erain
Copy link
Copy Markdown
Contributor

@erain erain commented Jan 13, 2026

Summary

  • expose get_metric_schema for GKE monitored resource schemas used in metrics queries
  • add schema docs for core Kubernetes/GKE resource types (cluster, node, node pool, pod, container, control plane component, service, scale, entity)
  • add unit test coverage for schema lookup

Details

  • validate supported resource types and map to embedded schema markdowns
  • document resource labels and example MQL filters based on the Monitoring resources catalog

References

Testing

  • go test ./pkg/tools/monitoring

@erain erain requested a review from a team as a code owner January 13, 2026 16:13
@google-oss-prow google-oss-prow Bot requested review from adamparco and juli4n January 13, 2026 16:13
@erain erain force-pushed the feat/get-metric-schema branch from f5fff3b to 74892e5 Compare January 13, 2026 16:19
@erain erain marked this pull request as draft January 13, 2026 16:20
@erain erain force-pushed the feat/get-metric-schema branch from 74892e5 to 4e75830 Compare January 13, 2026 16:27
@erain erain changed the title Add get_metric_schema tool and GKE metric schemas Add get_metric_schema for GKE resource schemas Jan 13, 2026
@erain erain force-pushed the feat/get-metric-schema branch from 4e75830 to 886a5dc Compare January 13, 2026 16:38
@google-oss-prow google-oss-prow Bot added size/XL and removed size/L labels Jan 13, 2026
@erain erain force-pushed the feat/get-metric-schema branch from 886a5dc to 7424043 Compare January 15, 2026 04:05
@erain erain marked this pull request as ready for review January 15, 2026 04:25
@bradhoekstra
Copy link
Copy Markdown
Collaborator

/assign @juli4n

@erain erain force-pushed the feat/get-metric-schema branch from 7424043 to 9c23779 Compare January 19, 2026 19:27
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@erain erain marked this pull request as draft January 20, 2026 02:19
@erain
Copy link
Copy Markdown
Contributor Author

erain commented Jan 20, 2026

I am blocking this PR until I do a full testing of all the sample queries. I will attach the test results as comments.

@bradhoekstra bradhoekstra removed the request for review from a team May 5, 2026 19:02
@GinnyJI
Copy link
Copy Markdown
Contributor

GinnyJI commented May 7, 2026

Removing reviewers because this pr has been in draft stage for 4 months. Feel free to add reviewers back once this pr is ready.

@GinnyJI GinnyJI removed their request for review May 7, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants