Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Timeout values added - #16

Open
alekhyal wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
alekhyal:master
Open

Timeout values added#16
alekhyal wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
alekhyal:master

Conversation

@alekhyal

Copy link
Copy Markdown

Added Timeout values for both blue-green-upgrade and expand-contract-upgrade in Gke-rolling-updates-demo repo. I verified the timeout values and added a buffer '1m' more..the way you asked me to.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@chrislovecnm

Copy link
Copy Markdown
Contributor

Test this please

@chrislovecnm chrislovecnm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question

kubectl -n default create -f "${REPO_HOME}/manifests/es-master-pdb.yaml"
kubectl -n default create -f "${REPO_HOME}/manifests/es-master.yaml"
kubectl -n default rollout status -f "${REPO_HOME}/manifests/es-master.yaml"
kubectl -n default rollout status --timeout=2m -f "${REPO_HOME}/manifests/es-master.yaml"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should eventually loop here if this fails. But this work for now?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works for now. I added a buffer of extra '1m' as you said sometimes cloud can act crazy.

@chrislovecnm

Copy link
Copy Markdown
Contributor

Test this please

@chrislovecnm

Copy link
Copy Markdown
Contributor

/approve

@google-oss-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrislovecnm

Copy link
Copy Markdown
Contributor

/assign

@chrislovecnm

Copy link
Copy Markdown
Contributor

Test this please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants