Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Fix Rolling update CI issue in teardown - #22

Open
homernajafi wants to merge 4 commits into
GoogleCloudPlatform:masterfrom
homernajafi:fixci
Open

Fix Rolling update CI issue in teardown#22
homernajafi wants to merge 4 commits into
GoogleCloudPlatform:masterfrom
homernajafi:fixci

Conversation

@homernajafi

Copy link
Copy Markdown
Contributor

Only teardown the cluster if exists.

@helmsman-bot

Copy link
Copy Markdown

Can one of the admins verify this patch?

@google-oss-robot google-oss-robot added the gke-helmsman PSO helmsman project label Mar 12, 2019
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-oss-robot

Copy link
Copy Markdown

Hi @homernajafi. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@chrislovecnm chrislovecnm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@chrislovecnm

Copy link
Copy Markdown
Contributor

/approve
/lgtm

chrislovecnm
chrislovecnm previously approved these changes Mar 14, 2019
@chrislovecnm

Copy link
Copy Markdown
Contributor

test this please

@google-oss-robot

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@google-oss-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, homernajafi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, homernajafi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@homernajafi

Copy link
Copy Markdown
Contributor Author

test this please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants