This repository was archived by the owner on Sep 16, 2022. It is now read-only.
Add support for structs embedded by pointer #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GoogleCloudPlatform#36 (more), and adds a test to ensure that embed-by-val and embed-by-ptr both continue to work.
riannucci
force-pushed
the
fix_embedded_structs
branch
from
ebbed8e to
50cfd24
Compare
Contributor
Author
|
(force pushed to improve commit message) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the embed-by-pointer issue that's related to #36. It also adds a test to ensure that embedding works at all.