Skip to content

ai:chore: Implement direct types for: EnterpriseKnowledgeGraphEntityReconciliationJob#10813

Open
hopper-coder-bot wants to merge 2 commits into
GoogleCloudPlatform:masterfrom
hopper-coder-bot:issue-9293-1782335139
Open

ai:chore: Implement direct types for: EnterpriseKnowledgeGraphEntityReconciliationJob#10813
hopper-coder-bot wants to merge 2 commits into
GoogleCloudPlatform:masterfrom
hopper-coder-bot:issue-9293-1782335139

Conversation

@hopper-coder-bot

Copy link
Copy Markdown
Collaborator

This PR scaffolds the initial KRM types, CRD, and IdentityV2 for the EnterpriseKnowledgeGraphEntityReconciliationJob resource under the enterpriseknowledgegraph.cnrm.cloud.google.com/v1alpha1 group using the direct approach.

Specifically, this PR:

  1. Scaffolds EnterpriseKnowledgeGraphEntityReconciliationJobSpec, EnterpriseKnowledgeGraphEntityReconciliationJobStatus, and related types under apis/enterpriseknowledgegraph/v1alpha1/.
  2. Implements IdentityV2 interface and reference structs in apis/enterpriseknowledgegraph/v1alpha1/.
  3. Generates the CRD manifest.
  4. Registers the new resource GVK with RBAC/Cluster roles and the gcpurls template registry.

This PR does not contain the controller or mapper steps, keeping the change focused on types and schemas.

Chore reference: .agents/greenfield-direct-new-resource-types.md

Fixes #9293


This PR was generated by the overseer agent (powered by the gemini-3.5-flash model).

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

1 similar comment
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@hopper-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating validations failure

Run: 28131808598
Name: validations
Cause: Code Error
Details: The code generator controller-gen panicked when parsing the new files because the generated deepcopy files were missing helper methods for the reference types.
Action Taken: Fix applied. Regenerated deepcopy helper methods and verified that the apis/ package successfully compiles and passes controller-gen checks.

Investigating validate-generated-files failure

Run: 28131808580
Name: validate-generated-files
Cause: Code Error
Details: The generated deepcopy file (zz_generated.deepcopy.go) was out of sync, and the project's CRD reports (docs/reports/crd_report.csv and docs/reports/crd_report.md) were not updated to list the new EnterpriseKnowledgeGraphEntityReconciliationJob CRD.
Action Taken: Fix applied. Regenerated all files and reports, and committed the changes.

Investigating unit-tests failure

Run: 28131808580
Name: unit-tests
Cause: Test Failure
Details: The API check test TestCRDFieldPresenceInTestsForAlpha failed because the newly introduced fields under the EnterpriseKnowledgeGraphEntityReconciliationJob CRD were not covered by tests and were not excluded.
Action Taken: Fix applied. Added exceptions for the new fields to tests/apichecks/testdata/exceptions/alpha-missingfields.txt via WRITE_GOLDEN_OUTPUT=1.

Investigating unit-tests-operator failure

Run: 28131808580
Name: unit-tests-operator
Cause: Test Failure
Details: The operator's golden tests failed because the expected YAML files were not updated with the cluster role and permissions configuration for the newly added enterpriseknowledgegraph.cnrm.cloud.google.com API group.
Action Taken: Fix applied. Regenerated the operator channels and updated the golden expectations in operator/pkg/controllers/configconnector/testdata/golden/simple/_expected.yaml.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

21 similar comments
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@hopper-coder-bot

Copy link
Copy Markdown
Collaborator Author

/retest

Investigating tests-e2e-fixtures-memorystore failure

Run: 29434254923
Name: tests-e2e-fixtures-memorystore
Cause: Infrastructure
Details: The workflow run failed because the Downloading envtest assets... step encountered a transient network connection reset (unable to perform request to get index: Get "https://raw.githubusercontent.com/kubernetes-sigs/controller-tools/HEAD/envtest-releases.yaml": read tcp 10.1.0.54:43192->185.199.110.133:443: read: connection reset by peer). Due to this transient network failure, the envtest environment (specifically the etcd binary) was not installed, causing the subsequent E2E test runs to fail with failed to start the controlplane. retried 5 times: exec: "etcd": executable file not found in PATH.
Action Taken: Rerun triggered via commenting /retest on the PR.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

3 similar comments
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

…conciliationJob

This commit scaffolds KRM types, generates CRD, and implements IdentityV2
and references for EnterpriseKnowledgeGraphEntityReconciliationJob.

Issue: 9293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/direct chore/ai greenfield Indicates implementation of a new resource (vs migration) overseer priority/medium step/gen-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ai:chore: Implement direct types for: EnterpriseKnowledgeGraphEntityReconciliationJob

3 participants