Skip to content

Greenfield: Implement direct KRM types, identity, and generate.sh for SecurityCenterManagementSecurityHealthAnalyticsCustomModule#11415

Open
ada-coder-bot wants to merge 5 commits into
GoogleCloudPlatform:masterfrom
ada-coder-bot:issue-11397-1783384470
Open

Greenfield: Implement direct KRM types, identity, and generate.sh for SecurityCenterManagementSecurityHealthAnalyticsCustomModule#11415
ada-coder-bot wants to merge 5 commits into
GoogleCloudPlatform:masterfrom
ada-coder-bot:issue-11397-1783384470

Conversation

@ada-coder-bot

Copy link
Copy Markdown
Collaborator

Greenfield implementation of direct KRM types, identity, and generate.sh for SecurityCenterManagementSecurityHealthAnalyticsCustomModule.

In this change, we:

  1. Scaffolded apis/securitycentermanagement/v1alpha1 directory and added doc.go, groupversion_info.go, and generate.sh.
  2. Implemented direct KRM types in apis/securitycentermanagement/v1alpha1/securitycentermanagementsecurityhealthanalyticscustommodule_types.go.
  3. Implemented identity interface with gcpurls.Template in apis/securitycentermanagement/v1alpha1/securitycentermanagementsecurityhealthanalyticscustommodule_identity.go.
  4. Implemented reference type and normalization logic in apis/securitycentermanagement/v1alpha1/securitycentermanagementsecurityhealthanalyticscustommodule_reference.go.
  5. Added unit tests for FromExternal identity parsing.
  6. Generated CRDs, clientsets, and static config files.

This PR was generated by the overseer,overseer,step/gen-types,greenfield agent (powered by the gemini-3.5-flash model).

Fixes #11397

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11397-1783384470 branch from 76b15ec to db2656f Compare July 7, 2026 01:27
@ada-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating unit-tests failure

Run: 28834206997 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28834206997/job/85514463081)
Name: unit-tests
Cause: Code Error
Details: Compilation failed in package github.com/GoogleCloudPlatform/k8s-config-connector/pkg/controller/direct/securitycentermanagement because Expr_FromProto and Expr_ToProto (called by the generated mapper to translate google.type.Expr fields) were undefined in the package.
Action Taken: Implemented the missing handwritten mapper functions Expr_FromProto and Expr_ToProto in a new file pkg/controller/direct/securitycentermanagement/mapper.go.

Investigating run-linters failure

Run: 28834206997 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28834206997/job/85514463062)
Name: run-linters
Cause: Code Error
Details: The custom linters check failed because analysis was skipped due to compilation errors in the securitycentermanagement direct controller package (caused by the missing/undefined Expr mapper functions).
Action Taken: Created pkg/controller/direct/securitycentermanagement/mapper.go to provide the required Expr mapper implementations.

Investigating license-lint failure

Run: 28834206997 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28834206997/job/85514463141)
Name: license-lint
Cause: Code Error
Details: The license-lint task failed to download/build dependencies because the newly introduced client library cloud.google.com/go/securitycentermanagement was not added to the root go.mod file, which triggered an import lookup error when run under -mod=readonly.
Action Taken: Added the latest client library cloud.google.com/go/securitycentermanagement@v1.6.0 to the root go.mod and tidied up dependencies for both the main workspace and the mockgcp workspace.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@ada-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating unit-tests failure

Run: 28835002981 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28835002981/job/85516816065)
Name: unit-tests
Cause: Code Error
Details: The test TestCRDFieldPresenceInTestsForAlpha failed because the newly introduced SecurityCenterManagementSecurityHealthAnalyticsCustomModule CRD is not yet covered by any end-to-end test fixtures, and its fields were not documented in the alpha exceptions list.
Action Taken: Regenerated the alpha exceptions list tests/apichecks/testdata/exceptions/alpha-missingfields.txt.

Investigating validations failure

Run: 28835002962 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28835002962/job/85516815673)
Name: validations
Cause: Code Error
Details: The validation job failed because the generated Go code was out of date. Specifically, the generated deepcopy methods for the reference type SecurityCenterManagementSecurityHealthAnalyticsCustomModuleRef were missing from apis/securitycentermanagement/v1alpha1/zz_generated.deepcopy.go.
Action Taken: Ran dev/tasks/generate-types-and-mappers to automatically generate the missing deepcopy methods.

Investigating validate-generated-files failure

Run: 28835002981 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28835002981/job/85516816054)
Name: validate-generated-files
Cause: Code Error
Details: Failed because generated types were out of date.
Action Taken: Ran dev/tasks/generate-types-and-mappers to update the generated code.

Investigating unit-tests-operator failure

Run: 28835002981 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28835002981/job/85516816057)
Name: unit-tests-operator
Cause: Code Error
Details: The test TestGoldenConfigConnector/simple failed because adding the new securitycentermanagement API group changed the operator's generated cluster roles for Admin and Viewer, resulting in unexpected diffs against the operator's simple golden files.
Action Taken: Regenerated the operator simple golden file operator/pkg/controllers/configconnector/testdata/golden/simple/_expected.yaml by running operator unit tests with WRITE_GOLDEN_OUTPUT=true.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@ada-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating validate-generated-files failure

Run: 28837491557 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28837491557/job/85524231793)
Name: validate-generated-files
Cause: Code Error
Details: The generated CRD analysis report files (docs/reports/crd_report.csv and docs/reports/crd_report.md) were out-of-date because they did not include the newly added SecurityCenterManagementSecurityHealthAnalyticsCustomModule Greenfield resource.
Action Taken: Regenerated the report files by running dev/tasks/generate-resource-report, amended the previous autogen commit with the updated files, and force-pushed upstream.

Investigating validations failure

Run: 28837491566 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28837491566/job/85524231386)
Name: validations
Cause: Code Error
Details: The validation step failed because the generated CRD report files (docs/reports/crd_report.csv and docs/reports/crd_report.md) were out-of-date.
Action Taken: Regenerated the CRD report files and committed/pushed the updates.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@ada-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating validations failure

Run: 28839458812 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28839458812/job/85530226424)
Name: validations
Cause: Code Error
Details: The validation step failed because the generated Go clients for the newly added securitycentermanagement API group were out of date.
Action Taken: Regenerated the Go clients by running make generate-go-client ensure fmt, and pushed the updated files.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11397-1783384470 branch from af4fa5b to 717617d Compare July 7, 2026 20:21
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

3 similar comments
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11397-1783384470 branch from db181a5 to 751d636 Compare July 15, 2026 09:35
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11397-1783384470 branch from 751d636 to 400b421 Compare July 15, 2026 09:58
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

6 similar comments
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11397-1783384470 branch from 400b421 to 264d777 Compare July 15, 2026 19:48
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11397-1783384470 branch from 264d777 to f47e9ef Compare July 15, 2026 22:09
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fedebongio for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

1 similar comment
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11397-1783384470 branch from f47e9ef to 0630506 Compare July 16, 2026 04:39
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

2 similar comments
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

… SecurityCenterManagementSecurityHealthAnalyticsCustomModule

Implement direct KRM types, identity, and generate.sh for the Greenfield resource SecurityCenterManagementSecurityHealthAnalyticsCustomModule.

In this change, we:
1. Scaffolded apis/securitycentermanagement/v1alpha1 directory and added doc.go, groupversion_info.go, and generate.sh.
2. Implemented direct KRM types in apis/securitycentermanagement/v1alpha1/securitycentermanagementsecurityhealthanalyticscustommodule_types.go.
3. Implemented identity interface with gcpurls.Template in apis/securitycentermanagement/v1alpha1/securitycentermanagementsecurityhealthanalyticscustommodule_identity.go.
4. Implemented reference type and normalization logic in apis/securitycentermanagement/v1alpha1/securitycentermanagementsecurityhealthanalyticscustommodule_reference.go.
5. Added unit tests for FromExternal identity parsing.
6. Generated CRDs, clientsets, and static config files.

Fixes GoogleCloudPlatform#11397
@ada-coder-bot
ada-coder-bot force-pushed the issue-11397-1783384470 branch from 0630506 to 1467c87 Compare July 20, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenfield Indicates implementation of a new resource (vs migration) overseer step/gen-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Greenfield: Implement direct KRM types, identity, and generate.sh for SecurityCenterManagementSecurityHealthAnalyticsCustomModule

3 participants