Skip to content

Greenfield: Implement direct KRM types, identity, and generate.sh for VertexAIIndex#11736

Open
hopper-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
hopper-coder-bot:issue-11726-1784421246
Open

Greenfield: Implement direct KRM types, identity, and generate.sh for VertexAIIndex#11736
hopper-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
hopper-coder-bot:issue-11726-1784421246

Conversation

@hopper-coder-bot

Copy link
Copy Markdown
Collaborator

This PR implements direct KRM types, identity, and generate.sh for VertexAIIndex in both v1alpha1 and v1beta1 packages.

  • Added VertexAIIndex:Index to generate.sh for both v1alpha1 and v1beta1 packages.
  • Created vertexaiindex_types.go matching the legacy Terraform schema to preserve backward compatibility.
  • Implemented IdentityV2 and refs.Ref using the canonical gcpurls.Template pattern in <kind>_identity.go and <kind>_reference.go.
  • Added unit tests for identity mapping.
  • Automatically updated CRDs and CAIS golden identities output.

Fixes #11726

This PR was generated by the overseer,overseer,step/gen-types,greenfield agent (powered by the gemini-3.5-flash model).

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anfernee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@hopper-coder-bot
hopper-coder-bot force-pushed the issue-11726-1784421246 branch from ae4a59d to 302414c Compare July 19, 2026 03:41
@hopper-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating validate-generated-files failure

Run: 29669481585
Name: validate-generated-files
Cause: Code Error
Details: Compilation errors in pkg/controller/direct/vertexai/datalabelingjob/vertexaidatalabelingjob_mapper.go because krm.Status was undefined (following the change of VertexAIIndex's status error field to use the common common.Status structure), and pkg/gvks/supportedgvks/gvks_generated.go was out of date because VertexAIIndex was promoted to a direct controller but still listed under legacyGVKs.
Action Taken: Fix applied. Imported common package in vertexaidatalabelingjob_mapper.go and converted krm.Status references to common.Status. Regenerated pkg/gvks/supportedgvks/gvks_generated.go via ./dev/tasks/generate-types-and-mappers. The commit was amended and force-pushed to the remote branch.

Investigating golangci-lint failure

Run: 29669481585
Name: golangci-lint
Cause: Code Error
Details: Compilation errors in pkg/controller/direct/vertexai/datalabelingjob/vertexaidatalabelingjob_mapper.go because krm.Status was undefined.
Action Taken: Fix applied. Fixed the compilation of vertexaidatalabelingjob_mapper.go by importing the common package and converting krm.Status to common.Status. The commit was amended and force-pushed to the remote branch.

Investigating run-linters failure

Run: 29669481585
Name: run-linters
Cause: Code Error
Details: Compilation errors in pkg/controller/direct/vertexai/datalabelingjob/vertexaidatalabelingjob_mapper.go because krm.Status was undefined.
Action Taken: Fix applied. Fixed the compilation of vertexaidatalabelingjob_mapper.go by importing the common package and converting krm.Status to common.Status. The commit was amended and force-pushed to the remote branch.

Investigating unit-tests failure

Run: 29669481585
Name: unit-tests
Cause: Code Error
Details: Compilation errors in pkg/controller/direct/vertexai/datalabelingjob/vertexaidatalabelingjob_mapper.go because krm.Status was undefined.
Action Taken: Fix applied. Fixed the compilation of vertexaidatalabelingjob_mapper.go by importing the common package and converting krm.Status to common.Status. The commit was amended and force-pushed to the remote branch.

Investigating validations failure

Run: 29669481603
Name: validations
Cause: Code Error
Details: Compilation errors in pkg/controller/direct/vertexai/datalabelingjob/vertexaidatalabelingjob_mapper.go because krm.Status was undefined.
Action Taken: Fix applied. Fixed the compilation of vertexaidatalabelingjob_mapper.go by importing the common package and converting krm.Status to common.Status. The commit was amended and force-pushed to the remote branch.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

1 similar comment
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@hopper-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating validate-generated-files failure

Run: 29672138190
Name: validate-generated-files
Cause: Code Error
Details: The KRM types files apis/vertexai/v1alpha1/vertexaiindex_types.go and apis/vertexai/v1beta1/vertexaiindex_types.go were missing the // +kubebuilder:metadata:labels="cnrm.cloud.google.com/tf2crd=true" annotation label. Since a direct reconciler/controller for VertexAIIndex is not yet implemented (this PR is only prep work implementing direct types and identity), the resource must still be reconciled by the legacy Terraform-based controller. Without this label, the static config generator failed to recognize VertexAIIndex as supported, leading to its accidental removal from pkg/controller/resourceconfig/static_config.go and causing the validation check to fail.
Action Taken: Added the tf2crd=true label to VertexAIIndex in both v1alpha1 and v1beta1 packages, regenerated the CRDs and GVK definitions, and successfully validated that all generated files are now clean and up-to-date. The commit was amended and force-pushed to the remote branch.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

This scaffolds the direct KRM types, identity, and reference parsing
for VertexAIIndex in both v1alpha1 and v1beta1 packages. It also regenerates
the CustomResourceDefinition with correct storageversion / stability labels
and updates CAIS golden identity files.

Fix: 11726
@hopper-coder-bot
hopper-coder-bot force-pushed the issue-11726-1784421246 branch from 9237588 to f7d2d99 Compare July 19, 2026 06:07
@hopper-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating validate-generated-files failure

Run: 29674078577
Name: validate-generated-files
Cause: Code Error
Details: The generated Google3 resource-reference documentation file scripts/generate-google3-docs/resource-reference/generated/resource-docs/vertexai/vertexaiindex.md was out-of-date due to missing properties on the newly added VertexAIIndex resource.
Action Taken: Regenerated the documentation by running make resource-docs and force-pushed the updated file.

Investigating unit-tests failure

Run: 29674078577
Name: unit-tests
Cause: Code Error
Details: TestNoRecursiveTypes failed because ListValue and Value types became marked as unreachable (commented out) in apis/vertexai/v1alpha1/types.generated.go following the regeneration. Since these types are no longer active, the exception [recursive_type] package=apis/vertexai/v1alpha1: ListValue -> Value -> ListValue in tests/apichecks/testdata/exceptions/recursivetypes.txt became obsolete and caused an unexpected diff check to fail.
Action Taken: Removed the obsolete VertexAI exception from recursivetypes.txt, validated that TestNoRecursiveTypes now successfully passes, and force-pushed the fix.

Investigating presubmit-gatekeeper failure

Run: 29674078577
Name: presubmit-gatekeeper
Cause: Code Error
Details: Failed as a downstream consequence of the validate-generated-files and unit-tests failures.
Action Taken: Force-pushed the required fixes which will allow downstream presubmits to pass cleanly.

(This report was generated by overseer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenfield Indicates implementation of a new resource (vs migration) overseer step/gen-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Greenfield: Implement direct KRM types, identity, and generate.sh for VertexAIIndex

2 participants