Greenfield: Implement direct KRM types, identity, and generate.sh for NetworkSecurityUrlList#11746
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
…rityUrlList
This commit adds support for the NetworkSecurityUrlList resource.
### Changes:
1. Updated apis/networksecurity/v1alpha1/generate.sh to include NetworkSecurityUrlList:UrlList.
2. Implemented KRM types in apis/networksecurity/v1alpha1/networksecurityurllist_types.go, defining NetworkSecurityUrlListSpec with fields matching the proto UrlList (description, values, labels), along with the metadata cnrm.cloud.google.com/stability-level=alpha.
3. Created apis/networksecurity/v1alpha1/networksecurityurllist_identity.go implementing identity.IdentityV2 via gcpurls.Template pointing to projects/{project}/locations/{location}/urlLists/{urllist}.
4. Created apis/networksecurity/v1alpha1/networksecurityurllist_reference.go to define and implement NetworkSecurityUrlListRef complying with the refs.Ref interface and registering it.
5. Added comprehensive unit tests in apis/networksecurity/v1alpha1/networksecurityurllist_identity_test.go verifying FromExternal and other identity helpers.
6. Regenerated types, deepcopy, and mappers using ./dev/tasks/generate-types-and-mappers.
7. Updated identities yaml test outputs for related alpha test fixtures.
8. Documented design decisions in .gemini/skills/kcc-direct-greenfield-types-implementer/journal/NetworkSecurityUrlList.md.
Issue: 11745
This PR was generated by the **overseer,overseer,step/gen-types,greenfield** agent (powered by the gemini-3.5-flash model).
cc2c6db to
045353b
Compare
Investigating validations failureRun: 29684906014 Investigating unit-tests failureRun: 29684906015 Investigating validate-generated-files failureRun: 29684906015 Investigating presubmit-gatekeeper failureRun: 29684906015 (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
This PR implements direct KRM types, identity, reference, and generate.sh for
NetworkSecurityUrlListunderapis/networksecurity/v1alpha1.Changes:
apis/networksecurity/v1alpha1/generate.shto includeNetworkSecurityUrlList:UrlList.apis/networksecurity/v1alpha1/networksecurityurllist_types.go, definingNetworkSecurityUrlListSpecwith fields matching the protoUrlList(description,values,labels), along with the metadatacnrm.cloud.google.com/stability-level=alpha.apis/networksecurity/v1alpha1/networksecurityurllist_identity.goimplementingidentity.IdentityV2viagcpurls.Templatepointing toprojects/{project}/locations/{location}/urlLists/{urllist}.apis/networksecurity/v1alpha1/networksecurityurllist_reference.goto define and implementNetworkSecurityUrlListRefcomplying with therefs.Refinterface and registering it.apis/networksecurity/v1alpha1/networksecurityurllist_identity_test.goverifying FromExternal and other identity helpers../dev/tasks/generate-types-and-mappers..gemini/skills/kcc-direct-greenfield-types-implementer/journal/NetworkSecurityUrlList.md.Fixes #11745
This PR was generated by the overseer,overseer,step/gen-types,greenfield agent (powered by the gemini-3.5-flash model).