Match real GCP behavior in MockGCP for NetworkServicesHTTPRoute#11748
Conversation
Implement MockGCP support for the NetworkServicesHTTPRoute resource, enabling local testing. Also add CreateTime, UpdateTime, and SelfLink properties on Mesh creation and update, allowing KCC's referenced resource resolver to correctly resolve referenced NetworkServicesMesh resources under mock. Lastly, register NetworkServicesHTTPRoute in config/tests/samples/create/harness.go so it's enabled under MockGCP tests. Issue: 11747
|
🤖 AI Factory started investigating CI check failures for this pull request. |
…e and Mesh - Refactor NetworkServicesMesh mock in MockGCP to use the correct LRO framework (StartLRO) rather than the simplified NewLRO. - Add operation-level name and metadata normalization rules to TestGoldenLogAlignment to ignore transient server-dependent fields. - Regenerate the mock golden files _http_mock.log and _generated_object_networkservicesmesh.golden.yaml for both networkservicesmesh and networkserviceshttproute to reflect the updated mock behavior. - Ensure all unit-tests and e2e mock tests pass successfully.
Investigating unit-tests failureRun: 29700658557
Investigating tests-e2e-fixtures-networkservices failureRun: 29700658557 Investigating presubmit-gatekeeper failureRun: 29700658557 (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
barney-s
left a comment
There was a problem hiding this comment.
/lgtm
/approve
golden_alignment changes seems iffy. we can revisit. @ldanielmadariaga ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f5ad9ef
This PR matches the real GCP behavior in MockGCP for the
NetworkServicesHTTPRouteresource, enabling robust local testing and verification.Real GCP Recording Report
record-gcpStatus: Successfully run against real GCP.cnrm-barni-4Key Changes
mockgcp/mocknetworkservices/httproute.goimplementingGetHttpRoute,ListHttpRoutes,CreateHttpRoute,UpdateHttpRoute, andDeleteHttpRouteendpoints for the NetworkServices service.CreateMeshandUpdateMeshinmockgcp/mocknetworkservices/mesh.goto properly storeCreateTime,UpdateTime, andSelfLinkvalues in MockGCP's storage. This ensures KCC's referenced resource resolver can successfully fetch and resolve referencedNetworkServicesMeshresources (such asmeshesref field in HTTPRoute) under mock testing.NetworkServicesHTTPRouteto the allowed MockGCP GroupKinds list inconfig/tests/samples/create/harness.go._http_mock.logbaseline log forNetworkServicesHTTPRouteand verified that mock E2E tests run 100% green.Fixes #11747
This PR was generated by the overseer,overseer agent (powered by the gemini-3.5-flash model).