Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump SecureSourceManager resources from v1alpha1 to v1beta1 #3747

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Bump SecureSourceManager resources from v1alpha1 to v1beta1 #3747

wants to merge 25 commits into from

Conversation

ericpang777
Copy link
Contributor

@ericpang777 ericpang777 commented Feb 20, 2025 •
edited
Loading

Change description

Followed https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/docs/develop-resources/deep-dives/5-releases.md#52-bump-from-v1alpha1-to-v1beta1.

  • ran git mv on the alpha folder to beta folder, but since the alpha folder is then gone, I copy pasted the folder back
  • updated package name to v1beta1
  • didn't update any direct controller imports (I am assuming this means any usages of SSM resources, but I don't think there are any users)
  • updated fixture tests to be v1beta1
  • added the tag to the instance and repository structs
  • ran generate-crds
  • added doc tmpl files as make ready-pr was failing due to it missing

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericpang777
Copy link
Contributor Author

ericpang777 commented Feb 20, 2025 •
edited
Loading

@gemmahou Ignore the old one #3705. This new PR is branched off #3746 and #3752

ericpang777
ericpang777 commented Feb 21, 2025
View reviewed changes
apis/securesourcemanager/v1beta1/groupversion_info.go

var (
// GroupVersion is group version used to register these objects
GroupVersion = schema.GroupVersion{Group: "securesourcemanager.cnrm.cloud.google.com", Version: "v1alpha1"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc never mentioned to update this version though, and I notice it wasn't updated for Redis either. Is this supposed to be updated?

pkg/gvks/supportedgvks/gvks_generated.go
Version: "v1beta1",
Kind: "SecureSourceManagerRepository",
}: {
Labels: map[string]string{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come the labels are different between instance and repository

...ogle3-docs/resource-reference/templates/securesourcemanager_securesourcemanagerinstance.tmpl
</tbody>
</table>

## Prerequisites
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this Prereq section here for both. Copied the wording off https://cloud.google.com/secure-source-manager/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericpang777