test: Remove unnecessary dependent project #3754
Open
+295
−1,034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -12,45 +12,18 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| apiVersion: resourcemanager.cnrm.cloud.google.com/v1beta1 | |||
| kind: Project | |||
There was a problem hiding this comment.
This seems like a dependency before you added your changes, and I wondered if it was done like this to avoid conflict because it uses the default network and quite some other Compute resources. Is it possible to keep using a different project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Followup of #3663.
The integration test is still failing after #3663 was merged. I realized all dependent resources must use the same project, example error message: Invalid value for field 'resource.backend_service': 'xxx'. Only external forwarding rules are allowed to reference cross-project backends. After I updated the projectRef for forwarding rule, the backendservice, network, subnetwork etc need to be updated to use the same dependent project.
I didn't notice this because in my local test, I replaced the dependent project with my cnrm project, making the main project(${projectId}) and the dependent project same. Then I realized that the dependent project might be unnecessary, as we may not need an extra project other than ${projectId} to create dependent resources.
Tests you have done
Gerrit cl: https://cnrm-review.git.corp.google.com/c/cnrm/+/72620
Tests passed: https://prow-gob.gcpnode.com/view/gs/cnrm-prow/pr-logs/pull/cnrm-review.googlesource.com_cnrm/72620/cnrm-test/1893043641480384512
make ready-prto ensure this PR is ready for review.