mockgcp: support for gcloud dataproc clusters #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Feb 22, 2025
justinsb
commented
- autogen: generate-script for gcloud dataproc clusters
- Manual fix for script for gcloud dataproc clusters
- tests: use real project id in tests when running against real GCP
- autogen: Capture golden output for mockdataproc/testdata/cluster/crud
- autogen: update Makefile for google.cloud.dataproc.v1
- autogen: updated GRPC/proto dependencies for google.cloud.dataproc.v1
- autogen: generate mockgcp for dataproc cluster
justinsb
force-pushed
the
gcloud_dataproc_clusters
branch
from
e869382 to
8e5d420
Compare
Also improvements to normalization
This header varies based on the length of dynamic values that we replace with placeholders.
justinsb
force-pushed
the
gcloud_dataproc_clusters
branch
from
8e5d420 to
ae15874
Compare
|
/assign @yuwenma |
yuwenma
reviewed
Feb 25, 2025
|
|
||
| package mockdataproc | ||
|
|
||
| func PtrTo[T any](t T) *T { |
There was a problem hiding this comment.
Or using this one
?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 75e890e
into
GoogleCloudPlatform:master
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.