chore: create script to generate github actions #3763
+381
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Feb 23, 2025
justinsb
commented
- chore: create script to generate github actions
- chore: remove generated tests from manually curated github actions file
- chore: rename validate-generated-types.sh to match pattern
By not including the extension, we can use this name in Github Actions etc.
justinsb
force-pushed
the
wire_up_tests_into_gha
branch
from
91d6a23 to
63293d7
Compare
|
/assign @yuwenma |
yuwenma
reviewed
Feb 25, 2025
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] |
There was a problem hiding this comment.
Do we want to reopen PRs? That could make the presubmit merge conflict become worse since reopen won't rebase.
| for f in $(find dev/ci/presubmits -type f | sort ); do | ||
| name=$(basename ${f}) | ||
|
|
||
| cat >> ${REPO_ROOT}/.github/workflows/ci-presubmit.yaml <<EOF |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.