Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockgcp: support for resource-manager tagkey #3766

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

justinsb
Copy link
Collaborator

  • autogen: generate-script for gcloud resource-manager tags keys
  • autogen: Capture golden output for mockresourcemanager/testdata/tagkey/crud
  • mockgcp: update service for resourcemanager tagkey
  • tests: fix confusion around unusual search syntax

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb justinsb force-pushed the gcloud_resourcemanager_tagkey branch from a460f65 to 49358fb Compare February 23, 2025 22:01
@justinsb justinsb force-pushed the gcloud_resourcemanager_tagkey branch from 49358fb to 2961569 Compare February 23, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant