-
Notifications
You must be signed in to change notification settings - Fork 297
Release 1.132.0 #4664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.132.0 #4664
Conversation
2ab10c0 to
ac4bd5d
Compare
operator/channels/packages/configconnector/1.131.0/namespaced/per-namespace-components.yaml
Outdated
Show resolved
Hide resolved
ffa4aff to
8dbd18f
Compare
8dbd18f to
e9e7f7e
Compare
|
/lgtm |
|
/assign @yuwenma |
e9e7f7e to
a1fb83d
Compare
| labels: (removed) | ||
| name: datacatalogpolicytags.datacatalog.cnrm.cloud.google.com | ||
| spec: (removed) | ||
| status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinsb I have to re-generate the golden log with the new release version. But do you know why there's extra changes (removed status field) in this file, in addition to the versions?
I feel it's fine to merge this PR for now to unblock release, and we can always re-generate the golden logs later if it causes issues.
|
/lgtm |
a1fb83d to
3d8995a
Compare
3d8995a to
7ddbf40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Looks good, could you run diff between 1.132 and 1.131 to share the CRD differences? It would also be used to help us verify the release note.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sure: https://paste.googleplex.com/4829435792195584 |
|
/lgtm |
828b9d8
into
GoogleCloudPlatform:master
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.