Skip to content

Conversation

@gemmahou
Copy link
Collaborator

@gemmahou gemmahou commented Jun 3, 2025

Change description

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@gemmahou gemmahou force-pushed the propose_tag_1.132.0 branch from 2ab10c0 to ac4bd5d Compare June 3, 2025 21:55
@gemmahou gemmahou force-pushed the propose_tag_1.132.0 branch 2 times, most recently from ffa4aff to 8dbd18f Compare June 3, 2025 22:25
@xiaoweim
Copy link
Collaborator

xiaoweim commented Jun 3, 2025

Could you please also update operator/pkg/controllers/configconnectorcontext/testdata/golden/simple/_expected.yaml , just checked and @justinsb has added some tests in #4528 three weeks ago on CCC, and we need to update the KCC version in that _expected.yaml

@gemmahou gemmahou force-pushed the propose_tag_1.132.0 branch from 8dbd18f to e9e7f7e Compare June 3, 2025 22:53
@xiaoweim
Copy link
Collaborator

xiaoweim commented Jun 3, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 3, 2025
@xiaoweim
Copy link
Collaborator

xiaoweim commented Jun 3, 2025

/assign @yuwenma

labels: (removed)
name: datacatalogpolicytags.datacatalog.cnrm.cloud.google.com
spec: (removed)
status:
Copy link
Collaborator Author

@gemmahou gemmahou Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinsb I have to re-generate the golden log with the new release version. But do you know why there's extra changes (removed status field) in this file, in addition to the versions?

I feel it's fine to merge this PR for now to unblock release, and we can always re-generate the golden logs later if it causes issues.

@xiaoweim
Copy link
Collaborator

xiaoweim commented Jun 4, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 4, 2025
@gemmahou gemmahou force-pushed the propose_tag_1.132.0 branch from a1fb83d to 3d8995a Compare June 4, 2025 17:54
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 4, 2025
@gemmahou gemmahou force-pushed the propose_tag_1.132.0 branch from 3d8995a to 7ddbf40 Compare June 4, 2025 18:10
Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Looks good, could you run diff between 1.132 and 1.131 to share the CRD differences? It would also be used to help us verify the release note.

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemmahou
Copy link
Collaborator Author

gemmahou commented Jun 4, 2025

/approve

Looks good, could you run diff between 1.132 and 1.131 to share the CRD differences? It would also be used to help us verify the release note.

Sure: https://paste.googleplex.com/4829435792195584
I only output the modified lines, not the newly added lines for 1.132.0 because they are huge. The diffs in _expected.yaml comes from the CC and CCC operator tests, we have to update the golden log to unblock the presubmit, I left a comment #4664 (comment) here.

@xiaoweim
Copy link
Collaborator

xiaoweim commented Jun 4, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 4, 2025
@google-oss-prow google-oss-prow bot merged commit 828b9d8 into GoogleCloudPlatform:master Jun 4, 2025
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants