Skip to content

Added a new GitHub Action to build binaries and attach it to the draft release#402

Merged
kyasbal merged 2 commits into
GoogleCloudPlatform:mainfrom
kyasbal:chore/release-process
Dec 5, 2025
Merged

Added a new GitHub Action to build binaries and attach it to the draft release#402
kyasbal merged 2 commits into
GoogleCloudPlatform:mainfrom
kyasbal:chore/release-process

Conversation

@kyasbal

@kyasbal kyasbal commented Dec 5, 2025

Copy link
Copy Markdown
Member
  • Added a GitHub Action job that is triggered on push to the specific release tags, it builds binaries and attach it to a draft release.
  • Pull request job now verifies go build succeeds

…t release

* Added a GitHub Action job that is triggered on push to the specific release tags, it builds binaries and attach it to a draft release.
* Pull request job now verifies go build succeeds
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @kyasbal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's continuous integration and release process by introducing an automated GitHub Action for building and attaching release binaries to draft releases. It also improves the robustness of pull request checks by explicitly verifying successful Go compilation. A minor adjustment to the binary naming convention streamlines the output filenames.

Highlights

  • New GitHub Action for Binary Builds: A new GitHub Action job has been introduced. This job is triggered upon pushes to specific release tags, and its purpose is to build project binaries and attach them to a draft release.
  • Go Build Verification in PRs: The existing pull request job has been updated to include a verification step, ensuring that the go build command successfully compiles the project.
  • Binary Naming Convention Update: The naming convention for the output binaries has been adjusted. The $(VERSION) variable is no longer included directly in the binary filename, simplifying the name to khi-$(GOARCH)-$(GOOS)$(3).
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/pullrequest.yaml
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build script to change the output binary naming format. While the change removes the version from the filename, which is suitable for release assets, the platform identifier ordering (ARCH-OS) is unconventional. My review includes a suggestion to align with the standard OS-ARCH convention to improve clarity and consistency.

Comment thread scripts/make/build.mk Outdated
@kyasbal kyasbal added dependencies Pull requests that update a dependency file cicd labels Dec 5, 2025
@kyasbal kyasbal merged commit 1b1db17 into GoogleCloudPlatform:main Dec 5, 2025
8 of 9 checks passed
@kyasbal kyasbal deleted the chore/release-process branch December 5, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cicd dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants