Merge main into epic/file-schema-v6#683
Merged
kyasbal merged 21 commits intoMay 21, 2026
Merged
Conversation
* Removing unused CORS code * Update pkg/core/init/default/defaultextension.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: kyasbal <kyasbal1994@gmail.com> --------- Signed-off-by: kyasbal <kyasbal1994@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…oogleCloudPlatform#599) * feat(startup): add inspection list components * feat(startup): implement smart component and integrate data loading GoogleCloudPlatform#558 * Fix name of the function pointed out by the review
…atform#629) * chore: fix make setup error in jj and update dev guide * fix commented issues on review
* Add Inventory/Discovery tasks for parsing the map from NEG name to BS name (GoogleCloudPlatform#635) * Add fleet PJ form task and query task to gather CSM TD audit logs (GoogleCloudPlatform#636) * Add Inventory/Discovery tasks for parsing the map from NEG name to BS name * Adding form task to receive the fleet project and query task to gather logs from Cloud Logging * Add timeline mapper for TD resource logs (GoogleCloudPlatform#637) * Add Inventory/Discovery tasks for parsing the map from NEG name to BS name * Adding form task to receive the fleet project and query task to gather logs from Cloud Logging * Add timeline mapper for traffic director resource logs
…Platform#638) * fix set-input suggestion being wrapped for every lines * Update web/src/app/timeline-toolbar/components/set-input-popup.component.scss Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: kyasbal <kyasbal1994@gmail.com> --------- Signed-off-by: kyasbal <kyasbal1994@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Addming make clean command * fixed commented points
… selected a timeline without point to a log (GoogleCloudPlatform#676)
… jump to other timing (GoogleCloudPlatform#677)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the header version display, adjusts log list item heights, and introduces a more robust scrolling mechanism in the timeline component that retries until the target position is reached. Key feedback includes concerns about state fragmentation when bypassing timeline updates in the selection manager, the O(N*M) performance complexity of the new computed property for finding timelines, and a suggestion to optimize the scroll retry logic by validating the event ID before performing DOM writes.
kyasbal
merged commit f31c0bd
into
GoogleCloudPlatform:epic/file-schema-v6
9 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these commits are approved on main side. I'll by-pass review to merge this on epic/file-schema-v6.