Define timeline style related variables from the previous enum packages#685
Merged
kyasbal merged 1 commit intoMay 22, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several new contract files across various inspection packages to register log types and severities for the timeline. The review feedback highlights that the use of style.MustForceConvertSRGBHex is deprecated due to incorrect color space mapping. It is recommended to replace these calls with direct style.Color struct definitions using display-p3 values to ensure accurate color rendering and adhere to the project's preference for local, simple definitions.
kyasbal
force-pushed
the
push-nzpzrploywky
branch
2 times, most recently
from
adbed47 to
bc90ee1
Compare
kyasbal
changed the title
kyasbal
force-pushed
the
push-nzpzrploywky
branch
from
bc90ee1 to
2d0c841
Compare
kyasbal
requested review from
RyuSA,
jyane,
kkuchima and
yfuruyama
as code owners
K53
approved these changes
May 22, 2026
kyasbal
merged commit 64b15f4
into
GoogleCloudPlatform:epic/file-schema-v6
9 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Verb, RevisionState, Severities and LogTypes defined in task packages. This will replace the
pkg/model/enumpackages used previously.We may need to review these strings later after fitting them into UI. For now, this PR is just creating these variables defined in the new file schema way.