Open
Conversation
Member
|
@ShubyM can you update the description with the details on how you tested it locally ? |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a GitHub Actions workflow to build and publish the kubectl-ai Docker image to GitHub Container Registry (GHCR), addressing issue #264. The workflow enables automated container image publishing for the project.
Key changes:
- Adds a new GitHub Actions workflow for Docker image publishing
- Configures GHCR as the target registry with proper authentication
- Sets up automated tagging with latest and timestamp-based tags
Comments suppressed due to low confidence (1)
.github/workflows/publish-image.yaml:15
- [nitpick] The job name 'build-and-push' is inconsistent with the actual job name 'build-and-publish' used in the PR description and testing instructions. Consider renaming to 'build-and-publish' for consistency.
build-and-push:
| with: | ||
| images: ${{ env.REGISTRY }}/${{ github.repository_owner }}/${{ env.IMAGE_NAME }} | ||
| tags: | | ||
| type=schedule,pattern={{date 'YYYYMMDD-HHmm' tz='UTC'}} |
There was a problem hiding this comment.
The workflow is triggered by 'workflow_dispatch' (manual trigger) but includes a 'type=schedule' tag pattern. This tag type is only relevant for scheduled workflows and will not be applied for manual triggers. Consider using 'type=ref,event=workflow_dispatch' or removing this tag type.
Suggested change
| type=schedule,pattern={{date 'YYYYMMDD-HHmm' tz='UTC'}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github action to publish kubectl-ai image to GHCR, part of #264.
Testing locally using act