Skip to content

WIP for Session Tests#497

Open
nisranjan wants to merge 43 commits intoGoogleCloudPlatform:mainfrom
nisranjan:session_persistance
Open

WIP for Session Tests#497
nisranjan wants to merge 43 commits intoGoogleCloudPlatform:mainfrom
nisranjan:session_persistance

Conversation

@nisranjan
Copy link
Contributor

@nisranjan nisranjan commented Aug 18, 2025 •
edited
Loading

@noahlwest
Just implement Session Tests for #466

It covers the following:

  • Creating a Session
  • Deleting a Session
  • Listing Session
  • Corrupted History file
  • Concurrent Session Access
  • Clear Session

A modification I made in session.go is to change the implementation of session file loading from entire JSON at one time to line by line so any corrupt JSON lines can be omitted

Another issue that I found out during testing is that GetLatestSession gets the first session, however it gets the latest session when a call to ListSession has already been made which sorts the slice of sessions, at the moment I am not sure if there is a use case of calling GetLatestSession without calling the ListSession(), because if there is a case for that then we should fix this.

@droot droot requested a review from noahlwest August 19, 2025 17:35
@nisranjan nisranjan mentioned this pull request Sep 4, 2025
Open
noahlwest
noahlwest approved these changes Sep 5, 2025
View reviewed changes
Copy link
Collaborator

@noahlwest noahlwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Overall looks good, just two minor comments.

@noahlwest noahlwest mentioned this pull request Sep 5, 2025
Closed
noahlwest and others added 7 commits September 8, 2025 13:20
@noahlwest
Fix setup-dev-cluster verification script (GoogleCloudPlatform#522)
7bd0cb2
@noahlwest
fix: GetLatestSession() does not get latest session (GoogleCloudPlatf…
9955aa9 
…orm#523)
@noahlwest
fix: address statefulset-lifecycle and list-images-for-pods consisten…
face4c8 
…t failures (GoogleCloudPlatform#525)

* Update statefulset-lifecycle prompt and verify to make eval less flaky

* Update list-images-for-pods eval to work with kind

* Remove unneeded verify.sh file
@noahlwest
Update prompt to be specific about our requirements so they're easier…
27895d6 
… to verify. Refactor verify.sh (GoogleCloudPlatform#524)
@droot
feat: always ask for approval for non-readonly commands (GoogleCloudP…
630a8e1 
…latform#510)
@nisranjan
WIP OpenAI Session Initialization and persistance GoogleCloudPlatform…
cd4a59c 
…#465
@nisranjan
WIP Added Initialize() method for Grok, enabling support for session …
4333acd 
…persistance, GoogleCloudPlatform#461 GoogleCloudPlatform#462
@nisranjan
Copy link
Contributor Author

nisranjan commented Sep 10, 2025 •
edited
Loading

@noahlwest @droot
The session_test.go did not make it to the kubectl-ai main branch, who need to do something push that to the main branch.
Will closing this PR automatically merge the files into the main branch?

@droot
Copy link
Member

droot commented Sep 10, 2025

@noahlwest @droot The session_test.go did not make it to the kubectl-ai main branch, who need to do something push that to the main branch. Will closing this PR automatically merge the files into the main branch?

Getting this in today. Thank you!

@droot
Copy link
Member

droot commented Sep 10, 2025

@noahlwest @droot The session_test.go did not make it to the kubectl-ai main branch, who need to do something push that to the main branch. Will closing this PR automatically merge the files into the main branch?

Getting this in today. Thank you!

presubmits are failing, you may want to run make check to make them pass.

bharats97 and others added 10 commits September 10, 2025 10:39
@bharats97
fix(mcp): handle object schemas without properties field (GoogleCloud…
184f94f 
…Platform#521)

MCP servers can return object schemas with additionalProperties
but no properties field, which is valid JSON Schema. The current
code panics when trying to convert such schemas.

This fix adds proper nil/existence checks before accessing the
properties field and gracefully handles object schemas that
rely on additionalProperties without explicit properties.

Fixes GoogleCloudPlatform#520
@prasad89
[Feature]: Support Ctrl+D to exit interactive mode (GoogleCloudPlatfo…
69dc4c0 
…rm#526)
@ShubyM
install mockgen (GoogleCloudPlatform#527)
961b2cc
@ShubyM
fix: go releaser (GoogleCloudPlatform#528)
9889830 
* install mockgen

* wrong mockgen
@ShubyM
fix: eval hangs (GoogleCloudPlatform#529)
5e8e0a9
@ShubyM
feat: e2e test for clear (GoogleCloudPlatform#513)
f4b1728
@zvdy
Fix/ci periodic (GoogleCloudPlatform#530)
3c1538f 
* fix: update Kind cluster setup action and add error handling in periodic CI workflow

* fix: reduce timeout values and improve retry logic in periodic eval workflow
@noahlwest
update k8s-bench results (GoogleCloudPlatform#533)
9578250 
* update k8s-bench results

* remove gemma results
@ShubyM
feat: add krew releaser step (GoogleCloudPlatform#532)
5f2fe1f
@ShubyM
fix: remove comment on krew.yaml (GoogleCloudPlatform#537)
9523cd6 
* add krew releaser step

* add generated from

* remove comment
noahlwest and others added 20 commits September 18, 2025 11:18
@noahlwest
feat: Add --show-failures flag to analyze-evals, update scripts (Go…
d1c3d83 
…ogleCloudPlatform#542)

* Add --show-failures flag to `analyze-evals`, update scripts

* Add string formatter to AddFailure call

* add --show-tool-output to eval runs
@ShubyM
feat: streamable-http server support (GoogleCloudPlatform#545)
62f1996
@noahlwest
Add timer to eval runs (GoogleCloudPlatform#547)
deb1836
@tdubenirmata
Fix auth directive being ignored in mcp.yaml config (GoogleCloudPla…
ad58bf2 
…tform#546)
@droot
fix: handle empty LLM response (GoogleCloudPlatform#551)
31c3629
@noahlwest
feat: add llm request/response tracing, http client timeout (GoogleCl…
abb02bf 
…oudPlatform#552)
@noahlwest
feat: Add ability to create new kind cluster for k8s-bench run (Googl…
12ec72c 
…eCloudPlatform#553)

* Add --create-kind-cluster flag to k8s-bench

* Make cluster name fixed, add logging
@droot
Made the system prompt to be human interaction aware (GoogleCloudPlat…
67273a6 
…form#555)
@nisranjan
WIP for Session Tests
4e22973 
Conflicts:
	go.mod

Changes to be committed:
	modified:   go.mod
	new file:   pkg/sessions/session_test.go
@nisranjan
Sessions Test Cases Complete GoogleCloudPlatform#466
98db964
@nisranjan
Changes as per comments GoogleCloudPlatform#497
3e43875
@nisranjan
WIP for Adding Session Init() for Azure Open AI GoogleCloudPlatform#459
9ecc7a6
@nisranjan
WIP OpenAI Session Initialization and persistance GoogleCloudPlatform…
3d96b24 
…#465
@nisranjan
WIP Added Initialize() method for Grok, enabling support for session …
267b13e 
…persistance, GoogleCloudPlatform#461 GoogleCloudPlatform#462
@nisranjan
Removed the ListSession() call in GetLatestSession(), so GoogleCloudP…
025a036 
…latform#518 now looks closed, also closes GoogleCloudPlatform#497
@nisranjan
chore(format): add license headers and gofmt via dev/tasks/format.sh
123954a
@nisranjan
Revert "chore(format): add license headers and gofmt via dev/tasks/fo…
325734a 
…rmat.sh"

This reverts commit 123954a.
@nisranjan
Reapply "chore(format): add license headers and gofmt via dev/tasks/f…
68b0066 
…ormat.sh"

This reverts commit 325734a.
@nisranjan
Revert "Reapply "chore(format): add license headers and gofmt via dev…
5cfe3fe 
…/tasks/format.sh""

This reverts commit 68b0066.
@nisranjan
Merge branch 'session_persistance' of https://github.com/nisranjan/ku…
b996f0c 
…bectl-ai into session_persistance
This was referenced Oct 9, 2025
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noahlwest noahlwest noahlwest approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nisranjan @droot @noahlwest @bharats97 @prasad89 @ShubyM @zvdy @tdubenirmata