feat: Add handling for openai full tool call in a single stream chunk (WIP)#559
Draft
noahlwest wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Draft
feat: Add handling for openai full tool call in a single stream chunk (WIP)#559noahlwest wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
noahlwest wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experimenting with Z.ai's GLM 4.6 model served with openai-compatible endpoint from vllm, and noticed that it gives output in a slightly different format from other models.
This change makes it operate successfully, though I'm not sure if this is the best way of making the change.
Here's an example of the last couple streaming chunks from a GLM tool request:
Here's an example from a different open model (Qwen3-Next-80B-A3B-Instruct) served with vllm that already works with our existing code: