Add yamls for metrics-based-autoscaling user guide.#2121
Conversation
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
NimJay
left a comment
There was a problem hiding this comment.
Thanks for these samples!
I trust that these manifests have been tested adequately.
Approved.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # [START gke_ai_ml_gke_slurm_metrics_autoscaling] |
There was a problem hiding this comment.
Issue:
The region tags need to be closed (i.e., we need [END gke_ai_ml_gke_slurm_metrics_autoscaling] at the bottom of this file).
This applies to all files.
ai-ml/gke-slurm/metrics-autoscaling/autoscaling-metrics.yaml:15, tag gke_ai_ml_gke_slurm_metrics_autoscaling doesn't have a matching end tag.
ai-ml/gke-slurm/metrics-autoscaling/pv-pvc.yaml:15, tag gke_ai_ml_gke_slurm_metrics_autoscaling doesn't have a matching end tag.
ai-ml/gke-slurm/metrics-autoscaling/values.yaml:15, tag gke_ai_ml_gke_slurm_metrics_autoscaling doesn't have a matching end tag.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # [START gke_ai_ml_gke_slurm_metrics_autoscaling] |
There was a problem hiding this comment.
Issue: We need to use distinct region tags for each file.
There was a problem hiding this comment.
This internal page might be helpful: go/code-snippets-101#code-snippet-anatomy
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Description
This PR introduces yamls used by user guide for setting up metrics-based autoscaling with slurm-operator and keda on GKE.
Tasks