Skip to content

Add yamls for metrics-based-autoscaling user guide.#2121

Open
pawloch00 wants to merge 5 commits into
GoogleCloudPlatform:mainfrom
pawloch00:main
Open

Add yamls for metrics-based-autoscaling user guide.#2121
pawloch00 wants to merge 5 commits into
GoogleCloudPlatform:mainfrom
pawloch00:main

Conversation

@pawloch00

Copy link
Copy Markdown

Description

This PR introduces yamls used by user guide for setting up metrics-based autoscaling with slurm-operator and keda on GKE.

Tasks

  • The contributing guide has been read and followed.
  • The samples added / modified have been fully tested.
  • Workflow files have been added / modified, if applicable.
  • Region tags have been properly added, if new samples.
  • Editable variables have been used, where applicable.
  • All dependencies are set to up-to-date versions, as applicable.
  • Merge this pull-request for me once it is approved.

pawloch00 added 4 commits July 1, 2026 08:54
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Signed-off-by: Piotr Pawłowski <ppawl@google.com>
@pawloch00
pawloch00 marked this pull request as ready for review July 14, 2026 12:55
@snippet-bot

snippet-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@NimJay NimJay left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these samples!

I trust that these manifests have been tested adequately.
Approved.

# See the License for the specific language governing permissions and
# limitations under the License.

# [START gke_ai_ml_gke_slurm_metrics_autoscaling]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue:
The region tags need to be closed (i.e., we need [END gke_ai_ml_gke_slurm_metrics_autoscaling] at the bottom of this file).
This applies to all files.

ai-ml/gke-slurm/metrics-autoscaling/autoscaling-metrics.yaml:15, tag gke_ai_ml_gke_slurm_metrics_autoscaling doesn't have a matching end tag.
ai-ml/gke-slurm/metrics-autoscaling/pv-pvc.yaml:15, tag gke_ai_ml_gke_slurm_metrics_autoscaling doesn't have a matching end tag.
ai-ml/gke-slurm/metrics-autoscaling/values.yaml:15, tag gke_ai_ml_gke_slurm_metrics_autoscaling doesn't have a matching end tag.

# See the License for the specific language governing permissions and
# limitations under the License.

# [START gke_ai_ml_gke_slurm_metrics_autoscaling]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: We need to use distinct region tags for each file.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This internal page might be helpful: go/code-snippets-101#code-snippet-anatomy

Signed-off-by: Piotr Pawłowski <ppawl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants