Promote Gemini Data Sharing With Google Setting Binding from google-beta to google

[PerlMonker303]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Promote resources for Gemini Admin Control

`google_gemini_data_sharing_with_google_setting_binding` (GA)

gemini: fixed permadiff on `product` field in `google_gemini_data_sharing_with_google_setting_binding` resource (Beta)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 692 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 1 insertion(+), 11 deletions(-))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gemini

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccGeminiDataSharingWithGoogleSettingBinding_update
  🟢 All tests passed!

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[shuyama1]

Running GA tests on TC. I'll update test result once it's done

[shuyama1]

Test failed due to error:

resource_gemini_data_sharing_with_google_setting_binding_test.go:23: Step 1/4 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_gemini_data_sharing_with_google_setting_binding.basic_binding will be updated in-place
          ~ resource "google_gemini_data_sharing_with_google_setting_binding" "basic_binding" {
                id                                  = "projects/ci-test-project-188019/locations/global/dataSharingWithGoogleSettings/tf-test-ls-anbpja9s28/settingBindings/tf-test-lsb-zpgyv39zxx"
                name                                = "projects/ci-test-project-188019/locations/global/dataSharingWithGoogleSettings/tf-test-ls-anbpja9s28/settingBindings/tf-test-lsb-zpgyv39zxx"
              - product                             = "GEMINI_CLOUD_ASSIST" -> null
                # (9 unchanged attributes hidden)
            }
        Plan: 0 to add, 1 to change, 0 to destroy.

I've checked our nightly tests and it seems the test has failed with the same error in our beta environment. Let's fix that in this PR.

The diff is likely due to the API returns default value for unset field product. https://googlecloudplatform.github.io/magic-modules/develop/diffs/#fix-diffs

[PerlMonker303]

I have encountered the error before, but it is weird how similar PRs did not have this error and they have identical setups - see #13051 and #13050.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 692 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• gemini

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccGeminiDataSharingWithGoogleSettingBinding_update

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGeminiDataSharingWithGoogleSettingBinding_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccGeminiDataSharingWithGoogleSettingBinding_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[shuyama1]

I have encountered the error before, but it is weird how similar PRs did not have this error and they have identical setups - see #13051 and #13050.

I think the issue occurs in google_gemini_data_sharing_with_google_setting_binding specifically. Modifying the test config would not fix the issue. This diff happens when the field is not explicitly specified but the API returns value. You'll need to add default_value: DEFAULT_VALUE or default_from_api: true to the field depends on if it has a fixed default value. See details at https://googlecloudplatform.github.io/magic-modules/develop/diffs/#default

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 693 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 2 insertions(+), 11 deletions(-))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gemini

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccGeminiDataSharingWithGoogleSettingBinding_update
  🟢 All tests passed!

View the build log

[PerlMonker303]

Added a fix after testing locally. This should work.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 693 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• gemini

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccGeminiDataSharingWithGoogleSettingBinding_update

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGeminiDataSharingWithGoogleSettingBinding_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGeminiDataSharingWithGoogleSettingBinding_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[shuyama1]

Added a fix after testing locally. This should work.

Thank you for updating the tests. I'd prefer we have the update test set as before - product field unset for creation and change it to a non-default value for update.
Running the previous test in GA, we got the following error:

=== RUN   TestAccGeminiDataSharingWithGoogleSettingBinding_update
=== PAUSE TestAccGeminiDataSharingWithGoogleSettingBinding_update
=== CONT  TestAccGeminiDataSharingWithGoogleSettingBinding_update
    resource_gemini_data_sharing_with_google_setting_binding_test.go:23: Step 3/4 error: Error running apply: exit status 1
        Error: Error waiting for Updating DataSharingWithGoogleSettingBinding: Error code 3, message: product "GEMINI_CODE_ASSIST" is not supported by the setting type "dataSharingWithGoogleSettings", allowed product is "GEMINI_CLOUD_ASSIST": invalid argument
          with google_gemini_data_sharing_with_google_setting_binding.basic_binding,
          on terraform_plugin_test.tf line 12, in resource "google_gemini_data_sharing_with_google_setting_binding" "basic_binding":
          12: resource "google_gemini_data_sharing_with_google_setting_binding" "basic_binding" {
--- FAIL: TestAccGeminiDataSharingWithGoogleSettingBinding_update (39.27s)

Is the GEMINI_CLOUD_ASSIST currently no supported? or is the value only supported in beta?

[PerlMonker303]

"GEMINI_CLOUD_ASSIST" should be supported. I have changed the tests now, let me know if it passes.

[shuyama1]

GEMINI_CODE_ASSIST

Sorry, I mean "GEMINI_CODE_ASSIST" (the non-default value). Is that supported? as we set it before in the test and the GA failure indicated that it was not supported. If not, we may want to remove it from possible value for ga resource.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 694 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 4 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gemini

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccGeminiDataSharingWithGoogleSettingBinding_update
  🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 693 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• gemini

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccGeminiDataSharingWithGoogleSettingBinding_update

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGeminiDataSharingWithGoogleSettingBinding_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGeminiDataSharingWithGoogleSettingBinding_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[PerlMonker303]

Sorry for the confusion, you are right. GEMINI_CODE_ASSIST is not supported for the product field for this resource. I removed it from possible values. I think things should be good to go now.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 694 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 3 files changed, 6 insertions(+), 15 deletions(-))

[modular-magician]

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• gemini

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccGeminiDataSharingWithGoogleSettingBinding_update
  🟢 All tests passed!

View the build log