feature: ephemeral write-only support #13135

BBBmau · 2025-02-20T19:33:15Z

This PR adds support for Write-Only attributes with the release of TF 1.11

It includes the following attributes:

Some PRs that were necessary to support Write-Only attributes:

Release Note Template for Downstream PRs (will be copied)

sql: added `password_wo` and `password_wo_version` fields to `google_sql_user` resource

bigquerydatatransfer: added `secret_access_key_wo` write-only field to `google_bigquery_data_transfer_config` resource

secretmanager: added `secret_version_wo` write-only field to `google_secret_version` resource

… docs (GoogleCloudPlatform#12550)

…tform#12974)

…ttribute` support (GoogleCloudPlatform#13048)

…TURE-BRANCH-ephemeral-write-only

)

…oogleCloudPlatform#12800) Co-authored-by: Zhenhua Li <[email protected]>

…gleCloudPlatform#13011)

modular-magician · 2025-02-20T19:44:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 257 files changed, 2789 insertions(+), 2203 deletions(-))
google-beta provider: Diff ( 257 files changed, 2789 insertions(+), 2203 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

modular-magician · 2025-02-20T21:06:47Z

Tests analytics

Total tests: 4609
Passed tests: 4169
Skipped tests: 433
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccSqlUser_password_wo

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSpannerInstance_spannerInstanceWithAutoscaling

Get to know how VCR tests work

modular-magician · 2025-02-20T21:17:04Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/third_party/terraform/services/sql/resource_sql_user_test.go

Co-authored-by: Riley Karson <[email protected]>

modular-magician · 2025-02-20T21:34:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 257 files changed, 2787 insertions(+), 2203 deletions(-))
google-beta provider: Diff ( 257 files changed, 2787 insertions(+), 2203 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

BBBmau · 2025-02-20T22:23:55Z

TeamCity Builds testing the resources with Write-Only attributes:

Bigquerydatatransfer
Sql
secretManager

rileykarson

Going through failing tests for now, I'll make a full run through the code tomorrow. The BQ change and a docs change didn't go through earlier dedicated review, and not sure if a full review was the expectation on the feature branch merge PR.

Breakdown by test:

TestAccDataSourceGoogleGkeHubFeature_basic seems unrelated. I'm not entirely sure what's going wrong, but it's VCR mechanics and doesn't seem to have been touched here.
TestAccSpannerInstance_spannerInstanceWithAutoscaling has a non-deterministic source of randomisation. I'll fix that. edit: #13141
TestAccAccessContextManager is likely failing due to messiness/conflicts in the environment.
TestAccCloudbuildWorkerPool_basic is failing in nightlies
TestAccEphemeralServiceAccountKey_basic seems like it may be related
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample can't pass yet in VCR but did in TC
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample can't pass yet in VCR but did in TC
TestAccSqlUser_password_wo was added but won't pass yet in VCR but did in TC

@BBBmau can you link successful runs for the WO tests, and investigate and provide context on or fix the TestAccEphemeralServiceAccountKey_basic failure? edit ah, you just beat me with most of them. Thanks!

See comment inline on bigquerydatatransfer, also, a test/test(s) should be added.

mmv1/products/bigquerydatatransfer/Config.yaml

rileykarson · 2025-02-20T22:30:40Z

Bigquerydatatransfer

No tests ran in that one, see comment above!

modular-magician · 2025-02-20T22:56:57Z

Tests analytics

Total tests: 4610
Passed tests: 4171
Skipped tests: 432
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSpannerInstance_spannerInstanceWithAutoscaling

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-02-20T23:06:04Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-21T19:25:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 258 files changed, 2793 insertions(+), 2213 deletions(-))
google-beta provider: Diff ( 258 files changed, 2793 insertions(+), 2213 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

modular-magician · 2025-02-26T00:18:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 611 insertions(+), 76 deletions(-))
google-beta provider: Diff ( 14 files changed, 611 insertions(+), 76 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 1 insertion(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key            = # value needed
    secret_access_key_wo         = # value needed
    secret_access_key_wo_version = # value needed
  }
}

modular-magician · 2025-02-26T00:37:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 611 insertions(+), 76 deletions(-))
google-beta provider: Diff ( 14 files changed, 611 insertions(+), 76 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 1 insertion(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key            = # value needed
    secret_access_key_wo         = # value needed
    secret_access_key_wo_version = # value needed
  }
}

modular-magician · 2025-02-26T00:58:42Z

Tests analytics

Total tests: 4632
Passed tests: 4191
Skipped tests: 434
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-02-26T01:17:53Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-26T01:30:25Z

Tests analytics

Total tests: 4632
Passed tests: 4191
Skipped tests: 434
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-02-26T01:31:04Z

Tests analytics

Total tests: 4632
Passed tests: 4191
Skipped tests: 434
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-02-26T01:36:58Z

Tests analytics

Total tests: 4525
Passed tests: 4106
Skipped tests: 413
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccSqlUser_password_wo

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

Get to know how VCR tests work

modular-magician · 2025-02-26T01:39:36Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-26T01:42:26Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-26T01:48:05Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-26T01:48:28Z

Tests analytics

Total tests: 4525
Passed tests: 4106
Skipped tests: 413
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccSqlUser_password_wo

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

Get to know how VCR tests work

modular-magician · 2025-02-26T02:07:30Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-26T02:19:08Z

Tests analytics

Total tests: 4632
Passed tests: 4192
Skipped tests: 434
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-02-26T02:27:15Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-26T02:36:58Z

Tests analytics

Total tests: 4632
Passed tests: 4192
Skipped tests: 434
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-02-26T02:45:00Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Riley Karson <[email protected]>

BBBmau and others added 15 commits December 18, 2024 14:49

EphemeralWriteOnly: Initial support for MMv1 Generation in schema &…

62e1ef2

… docs (GoogleCloudPlatform#12550)

ephemeralWriteOnly: fix build error (GoogleCloudPlatform#12786)

e0ebb92

prevent properties to be forceNew if parent is immutable

c11e55d

remove writeOnly from expand_property_method_.go.tmpl

f654602

go.mod latest dependency versions

5d4f0b1

mmv1: add hashicorp/gocty/cty in resource.go.tmpl (GoogleCloudPla…

dddb91c

…tform#12974)

add raw_resource_config_validation for `validation.PreferWriteOnlyA…

010ecb3

…ttribute` support (GoogleCloudPlatform#13048)

Merge branch 'FEATURE-BRANCH-ephemeral-write-only' into sync-main-FEA…

9a9293f

…TURE-BRANCH-ephemeral-write-only

go mod tidy

78e0373

go-cidr

d7bd063

Sync main feature branch ephemeral write only (GoogleCloudPlatform#13112

5c0ea7b

)

EphemeralWriteOnly: add secret_data_wo in google_secret_version (G…

a04dfc3

…oogleCloudPlatform#12800) Co-authored-by: Zhenhua Li <[email protected]>

EphemeralWriteOnly: add secretAccessKeyWo (GoogleCloudPlatform#12967)

81a26f8

add write-only guide (GoogleCloudPlatform#13117)

b463610

EphemeralWriteOnly: add password_wo field to google_sql_user (Goo…

7533392

…gleCloudPlatform#13011)

BBBmau requested a review from rileykarson February 20, 2025 19:33

modular-magician added the service/terraform label Feb 20, 2025

rileykarson reviewed Feb 20, 2025

View reviewed changes

mmv1/third_party/terraform/services/sql/resource_sql_user_test.go Outdated Show resolved Hide resolved

Update mmv1/third_party/terraform/services/sql/resource_sql_user_test.go

c1a9d51

Co-authored-by: Riley Karson <[email protected]>

rileykarson reviewed Feb 20, 2025

View reviewed changes

mmv1/products/bigquerydatatransfer/Config.yaml Show resolved Hide resolved

bigquerydatatransfer: fix diff on secret_access_key with write_only

c61acd7

go fmt

5db5ffc

BBBmau added this pull request to the merge queue Feb 26, 2025

Merged via the queue into GoogleCloudPlatform:main with commit d89901f Feb 26, 2025
23 of 24 checks passed

RooBarsic pushed a commit to RooBarsic/magic-modules that referenced this pull request Feb 27, 2025

feature: ephemeral write-only support (GoogleCloudPlatform#13135)

6489b84

Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Riley Karson <[email protected]>

maxi-cit pushed a commit to maxi-cit/magic-modules that referenced this pull request Feb 27, 2025

feature: ephemeral write-only support (GoogleCloudPlatform#13135)

822227e

Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Riley Karson <[email protected]>

NA2047 pushed a commit to NA2047/magic-modules that referenced this pull request Mar 13, 2025

feature: ephemeral write-only support (GoogleCloudPlatform#13135)

83f856e

Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Riley Karson <[email protected]>

JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 25, 2025

feature: ephemeral write-only support (GoogleCloudPlatform#13135)

24f425a

Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Riley Karson <[email protected]>

JaylonmcShan03 pushed a commit to JaylonmcShan03/magic-modules-jmcshan that referenced this pull request Mar 30, 2025

feature: ephemeral write-only support (GoogleCloudPlatform#13135)

552ba32

Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Riley Karson <[email protected]>

Dawid212 pushed a commit to Dawid212/magic-modules that referenced this pull request Apr 9, 2025

feature: ephemeral write-only support (GoogleCloudPlatform#13135)

364a14e

Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Riley Karson <[email protected]>

melinath mentioned this pull request Jun 3, 2025

compute: added shared_secret_wo and shared_secret_wo_version fields to google_compute_vpn_tunnel + changes to write_only implementation in generator/templating #14138

Open

feature: ephemeral write-only support #13135

feature: ephemeral write-only support #13135

Uh oh!

Conversation

BBBmau commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Feb 20, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Feb 20, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 20, 2025

Uh oh!

Uh oh!

modular-magician commented Feb 20, 2025

Diff report

Missing test report

Uh oh!

BBBmau commented Feb 20, 2025

Uh oh!

rileykarson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rileykarson commented Feb 20, 2025

Uh oh!

modular-magician commented Feb 20, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 20, 2025

Uh oh!

modular-magician commented Feb 21, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Feb 26, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Feb 26, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Feb 26, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 26, 2025

Uh oh!

modular-magician commented Feb 26, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 26, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 26, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 26, 2025

Uh oh!

modular-magician commented Feb 26, 2025

Uh oh!

modular-magician commented Feb 26, 2025

Uh oh!

modular-magician commented Feb 26, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Feb 26, 2025

Uh oh!

modular-magician commented Feb 26, 2025

BBBmau commented Feb 20, 2025 •

edited

Loading

rileykarson left a comment •

edited

Loading