feature: ephemeral write-only support #13135

BBBmau · 2025-02-20T19:33:15Z

This PR adds support for Write-Only attributes with the release of TF 1.11

It includes the following attributes:

Some PRs that were necessary to support Write-Only attributes:

Release Note Template for Downstream PRs (will be copied)

sql: added `password_wo` and `password_wo_version` fields to `google_sql_user` resource

bigquerydatatransfer: added `secret_access_key_wo` write-only field to `google_bigquery_data_transfer_config` resource

`secretmanager`: added `secret_version_wo` write-only field to `google_secret_version` resource

compute: added `raw_key_wo`, `rsa_encrypted_key` and `new_keys_wo` fields in `resource_google_compute_disk` resource

compute: added `raw_key_wo` and `new_keys_wo` fields in `resource_google_region_compute_disk` resource

… docs (GoogleCloudPlatform#12550)

…tform#12974)

…ttribute` support (GoogleCloudPlatform#13048)

…TURE-BRANCH-ephemeral-write-only

)

…oogleCloudPlatform#12800) Co-authored-by: Zhenhua Li <[email protected]>

…gleCloudPlatform#13011)

modular-magician · 2025-02-20T19:44:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 257 files changed, 2789 insertions(+), 2203 deletions(-))
google-beta provider: Diff ( 257 files changed, 2789 insertions(+), 2203 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

modular-magician · 2025-02-20T21:06:47Z

Tests analytics

Total tests: 4609
Passed tests: 4169
Skipped tests: 433
Affected tests: 7

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccSqlUser_password_wo

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-20T21:17:04Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/third_party/terraform/services/sql/resource_sql_user_test.go

Co-authored-by: Riley Karson <[email protected]>

modular-magician · 2025-02-20T21:34:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 257 files changed, 2787 insertions(+), 2203 deletions(-))
google-beta provider: Diff ( 257 files changed, 2787 insertions(+), 2203 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

BBBmau · 2025-02-20T22:23:55Z

TeamCity Builds testing the resources with Write-Only attributes:

Bigquerydatatransfer
Sql
secretManager

rileykarson

Going through failing tests for now, I'll make a full run through the code tomorrow. The BQ change and a docs change didn't go through earlier dedicated review, and not sure if a full review was the expectation on the feature branch merge PR.

Breakdown by test:

TestAccDataSourceGoogleGkeHubFeature_basic seems unrelated. I'm not entirely sure what's going wrong, but it's VCR mechanics and doesn't seem to have been touched here.
TestAccSpannerInstance_spannerInstanceWithAutoscaling has a non-deterministic source of randomisation. I'll fix that. edit: Use controlled random suffix for TestAccSpannerInstance_spannerInstanceWithAutoscaling #13141
TestAccAccessContextManager is likely failing due to messiness/conflicts in the environment.
TestAccCloudbuildWorkerPool_basic is failing in nightlies
TestAccEphemeralServiceAccountKey_basic seems like it may be related
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample can't pass yet in VCR but did in TC
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample can't pass yet in VCR but did in TC
TestAccSqlUser_password_wo was added but won't pass yet in VCR but did in TC

@BBBmau can you link successful runs for the WO tests, and investigate and provide context on or fix the TestAccEphemeralServiceAccountKey_basic failure? edit ah, you just beat me with most of them. Thanks!

See comment inline on bigquerydatatransfer, also, a test/test(s) should be added.

mmv1/products/bigquerydatatransfer/Config.yaml

rileykarson · 2025-02-20T22:30:40Z

No tests ran in that one, see comment above!

modular-magician · 2025-02-20T22:56:57Z

Tests analytics

Total tests: 4610
Passed tests: 4171
Skipped tests: 432
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-20T23:06:04Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-21T19:25:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 258 files changed, 2793 insertions(+), 2213 deletions(-))
google-beta provider: Diff ( 258 files changed, 2793 insertions(+), 2213 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

modular-magician · 2025-02-21T21:37:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 258 files changed, 2761 insertions(+), 2213 deletions(-))
google-beta provider: Diff ( 258 files changed, 2761 insertions(+), 2213 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

modular-magician · 2025-02-21T21:43:05Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-21T21:48:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 258 files changed, 2762 insertions(+), 2213 deletions(-))
google-beta provider: Diff ( 258 files changed, 2762 insertions(+), 2213 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

modular-magician · 2025-02-21T21:48:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 258 files changed, 2762 insertions(+), 2213 deletions(-))
google-beta provider: Diff ( 258 files changed, 2762 insertions(+), 2213 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

modular-magician · 2025-02-21T22:05:29Z

Tests analytics

Total tests: 4613
Passed tests: 4174
Skipped tests: 432
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-21T22:05:44Z

Tests analytics

Total tests: 4613
Passed tests: 4172
Skipped tests: 432
Affected tests: 9

Click here to see the affected service packages

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-21T22:16:00Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-21T22:24:37Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccFolderIamPolicy_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-21T23:46:36Z

Tests analytics

Total tests: 4614
Passed tests: 4175
Skipped tests: 432
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-21T23:49:16Z

Tests analytics

Total tests: 4614
Passed tests: 4175
Skipped tests: 432
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-21T23:52:36Z

Tests analytics

Total tests: 4614
Passed tests: 4175
Skipped tests: 432
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-21T23:55:24Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-22T00:00:45Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-22T00:06:00Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

rileykarson · 2025-02-24T23:45:44Z

mmv1/products/bigquerydatatransfer/Config.yaml

@@ -210,6 +211,12 @@ properties:
      **NOTE** : If you are attempting to update a parameter that cannot be updated (due to api limitations) [please force recreation of the resource](https://www.terraform.io/cli/state/taint#forcing-re-creation-of-resources).
    required: true
    custom_flatten: 'templates/terraform/custom_flatten/json_to_string_map.go.tmpl'
+
+  - name: 'sensitiveParamsWoVersion'


I'd lean more towards keeping the version field with the WO field. So we'd support sensitive_params.0.secret_access_key_wo_version here. While params is sent directly, sensitive_params isn't and is structured. That'll be easier to adapt later if we do introduce a template, and will keep a single pattern for all WO + WO version field pairs.

rileykarson · 2025-02-24T23:57:09Z

mmv1/templates/terraform/decoders/bigquery_data_transfer.go.tmpl

-			if _, exists := d.GetOkExists("sensitive_params.0." + sp); exists {
-				delete(params, sp)
-			} else {
-				params[sp] = d.Get("params." + sp)


Doesn't this change mean we'll remove values from state where we wouldn't before? This seems like a regression.

Previously the logic was:

do a presence check

if present and in sensitive_params, don't set in state

if present and not in sensitive_params, persist old state value

else record value in state (will diff from null)

The new logic is:

delete from state if present

you're correct, the regression comes from if a user decides to explicitly set a secret_access_key into params directly instead of sensitive_params. If a user were to do this with the current change it would delete from state (regression).

~~Latest commit reverts this and adds a config check of _wo attribute with RawConfigAt d5b47a4~~

There might be something wrong with how RawConfigAt works. It only works on creation. Was getting null as the result. Enforcing the check with version fixes the diff just fine but feels janky. I'll get back to you on whether this is a bug or if this is meant to be like this, just need to confirm. The new commit: 113b096

mmv1/third_party/terraform/website/docs/r/sql_user.html.markdown

mmv1/products/bigquerydatatransfer/Config.yaml

mmv1/products/secretmanager/SecretVersion.yaml

modular-magician · 2025-02-25T04:39:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 258 files changed, 2763 insertions(+), 2208 deletions(-))
google-beta provider: Diff ( 258 files changed, 2763 insertions(+), 2208 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 11 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key    = # value needed
    secret_access_key_wo = # value needed
  }
  sensitive_params_wo_version = # value needed
}

…ersion to be set

modular-magician · 2025-02-25T05:23:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 258 files changed, 2735 insertions(+), 2208 deletions(-))
google-beta provider: Diff ( 258 files changed, 2735 insertions(+), 2208 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 1 insertion(+), 1 deletion(-))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2025-02-25T05:27:16Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample
TestAccSqlUser_password_wo
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-02-25T05:32:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 258 files changed, 2735 insertions(+), 2208 deletions(-))
google-beta provider: Diff ( 258 files changed, 2735 insertions(+), 2208 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 1 insertion(+), 1 deletion(-))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician · 2025-02-25T05:35:55Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample
TestAccSqlUser_password_wo
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2025-02-25T06:44:38Z

Tests analytics

Total tests: 4616
Passed tests: 4177
Skipped tests: 432
Affected tests: 7

Click here to see the affected service packages

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-02-25T07:04:46Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

BBBmau and others added 15 commits December 18, 2024 14:49

EphemeralWriteOnly: Initial support for MMv1 Generation in schema &…

62e1ef2

… docs (GoogleCloudPlatform#12550)

ephemeralWriteOnly: fix build error (GoogleCloudPlatform#12786)

e0ebb92

prevent properties to be forceNew if parent is immutable

c11e55d

remove writeOnly from expand_property_method_.go.tmpl

f654602

go.mod latest dependency versions

5d4f0b1

mmv1: add hashicorp/gocty/cty in resource.go.tmpl (GoogleCloudPla…

dddb91c

…tform#12974)

add raw_resource_config_validation for `validation.PreferWriteOnlyA…

010ecb3

…ttribute` support (GoogleCloudPlatform#13048)

Merge branch 'FEATURE-BRANCH-ephemeral-write-only' into sync-main-FEA…

9a9293f

…TURE-BRANCH-ephemeral-write-only

go mod tidy

78e0373

go-cidr

d7bd063

Sync main feature branch ephemeral write only (GoogleCloudPlatform#13112

5c0ea7b

)

EphemeralWriteOnly: add secret_data_wo in google_secret_version (G…

a04dfc3

…oogleCloudPlatform#12800) Co-authored-by: Zhenhua Li <[email protected]>

EphemeralWriteOnly: add secretAccessKeyWo (GoogleCloudPlatform#12967)

81a26f8

add write-only guide (GoogleCloudPlatform#13117)

b463610

EphemeralWriteOnly: add password_wo field to google_sql_user (Goo…

7533392

…gleCloudPlatform#13011)

BBBmau requested a review from rileykarson February 20, 2025 19:33

modular-magician added the service/terraform label Feb 20, 2025

rileykarson reviewed Feb 20, 2025

View reviewed changes

mmv1/third_party/terraform/services/sql/resource_sql_user_test.go Outdated Show resolved Hide resolved

Update mmv1/third_party/terraform/services/sql/resource_sql_user_test.go

c1a9d51

Co-authored-by: Riley Karson <[email protected]>

rileykarson reviewed Feb 20, 2025

View reviewed changes

mmv1/products/bigquerydatatransfer/Config.yaml Show resolved Hide resolved

bigquerydatatransfer: fix diff on secret_access_key with write_only

c61acd7

password doc update + update-write-only link add

0d265d0

BBBmau force-pushed the FEATURE-BRANCH-ephemeral-write-only branch from 13c786b to 0d265d0 Compare February 21, 2025 21:36

BBBmau requested a review from rileykarson February 24, 2025 22:47

rileykarson reviewed Feb 25, 2025

View reviewed changes

revert decoder change and add rawConfigAt check for _wo field

d5b47a4

BBBmau added 3 commits February 24, 2025 21:09

move woVersion inside sensitiveParams + require both key_wo and _wo_v…

3eb3cab

…ersion to be set

use version to prevent diff

113b096

use relative links

06d949c

BBBmau requested a review from rileykarson February 25, 2025 05:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: ephemeral write-only support #13135

feature: ephemeral write-only support #13135

BBBmau commented Feb 20, 2025

modular-magician commented Feb 20, 2025

modular-magician commented Feb 20, 2025

modular-magician commented Feb 20, 2025

modular-magician commented Feb 20, 2025

BBBmau commented Feb 20, 2025

rileykarson left a comment •

edited

Loading

rileykarson commented Feb 20, 2025

modular-magician commented Feb 20, 2025

modular-magician commented Feb 20, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 22, 2025

modular-magician commented Feb 22, 2025

rileykarson Feb 24, 2025

rileykarson Feb 24, 2025

BBBmau Feb 25, 2025 •

edited

Loading

modular-magician commented Feb 25, 2025

modular-magician commented Feb 25, 2025

modular-magician commented Feb 25, 2025

modular-magician commented Feb 25, 2025

modular-magician commented Feb 25, 2025

modular-magician commented Feb 25, 2025

modular-magician commented Feb 25, 2025

feature: ephemeral write-only support #13135

Are you sure you want to change the base?

feature: ephemeral write-only support #13135

Conversation

BBBmau commented Feb 20, 2025

modular-magician commented Feb 20, 2025

Diff report

Missing test report

modular-magician commented Feb 20, 2025

Tests analytics

Action taken

modular-magician commented Feb 20, 2025

modular-magician commented Feb 20, 2025

Diff report

Missing test report

BBBmau commented Feb 20, 2025

rileykarson left a comment • edited Loading

Choose a reason for hiding this comment

rileykarson commented Feb 20, 2025

modular-magician commented Feb 20, 2025

Tests analytics

Action taken

modular-magician commented Feb 20, 2025

modular-magician commented Feb 21, 2025

Diff report

Missing test report

modular-magician commented Feb 21, 2025

Diff report

Missing test report

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

Diff report

Missing test report

modular-magician commented Feb 21, 2025

Diff report

Missing test report

modular-magician commented Feb 21, 2025

Tests analytics

Action taken

modular-magician commented Feb 21, 2025

Tests analytics

Action taken

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

modular-magician commented Feb 21, 2025

Tests analytics

Action taken

modular-magician commented Feb 21, 2025

Tests analytics

Action taken

modular-magician commented Feb 21, 2025

Tests analytics

Action taken

modular-magician commented Feb 21, 2025

modular-magician commented Feb 22, 2025

modular-magician commented Feb 22, 2025

rileykarson Feb 24, 2025

Choose a reason for hiding this comment

rileykarson Feb 24, 2025

Choose a reason for hiding this comment

BBBmau Feb 25, 2025 • edited Loading

Choose a reason for hiding this comment

modular-magician commented Feb 25, 2025

Diff report

Missing test report

modular-magician commented Feb 25, 2025

Diff report

Errors

modular-magician commented Feb 25, 2025

Tests analytics

modular-magician commented Feb 25, 2025

Diff report

Errors

modular-magician commented Feb 25, 2025

Tests analytics

modular-magician commented Feb 25, 2025

Tests analytics

Action taken

modular-magician commented Feb 25, 2025

rileykarson left a comment •

edited

Loading

BBBmau Feb 25, 2025 •

edited

Loading