Skip to content

api differences are resolved.#17719

Open
guvenenb wants to merge 10 commits into
GoogleCloudPlatform:mainfrom
guvenenb:api_parity
Open

api differences are resolved.#17719
guvenenb wants to merge 10 commits into
GoogleCloudPlatform:mainfrom
guvenenb:api_parity

Conversation

@guvenenb

@guvenenb guvenenb commented May 25, 2026

Copy link
Copy Markdown
Contributor

This Pull Request implements API parity for the google_vertex_ai_reasoning_engine resource by introducing several new configuration fields. At the root level, it adds the output-only url
│ field and traffic_config to support traffic splitting configurations (both manual and always-latest). Within the deployment specifications, it introduces agent_server_mode ,
│ agent_gateway_config (for secure inbound and outbound traffic via Google-managed gateways), and keep_alive_probe . Finally, it updates the agent's spec with agent_card and example_store
│ support, and adds example_store_config to the context_spec for similarity search configurations. All these fields are introduced as beta features.

vertexai: Added `traffic_config`, `url`, `agent_server_mode`, `agent_gateway_config`, `keep_alive_probe`, `agent_card`, `example_store`, and `example_store_config` fields to `google_vertex_ai_reasoning_engine` (beta)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 25, 2026
@github-actions github-actions Bot requested a review from NickElliot May 25, 2026 11:19
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@guvenenb

Copy link
Copy Markdown
Contributor Author

Hi @NickElliot, can you look and review this PR, it is quite urgent, I would be very grateful if you could take the time to look at it. Thank you a lot!

@modular-magician modular-magician added service/aiplatform-agent-engine and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels May 27, 2026
@modular-magician

modular-magician commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a5e85dc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 138 insertions(+)
google-beta provider View Diff 4 files changed, 991 insertions(+), 10 deletions(-)
terraform-google-conversion View Diff 1 file changed, 376 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_reasoning_engine (24 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_reasoning_engine" "primary" {
  context_spec {
    example_store_config {
      similarity_search_config {
        embedding_model = # value needed
      }
    }
  }
  spec {
    agent_card = # value needed
    deployment_spec {
      agent_gateway_config {
        agent_to_anywhere_config {
          agent_gateway = # value needed
        }
        client_to_agent_config {
          agent_gateway = # value needed
        }
      }
      keep_alive_probe {
        http_get {
          path = # value needed
          port = # value needed
        }
        max_seconds = # value needed
      }
    }
    example_store = # value needed
  }
  traffic_config {
    traffic_split_manual {
      targets {
        percent               = # value needed
        runtime_revision_name = # value needed
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
95 90 4 1
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@guvenenb, @NickElliot VCR tests complete for a5e85dc!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label May 28, 2026
@github-actions

Copy link
Copy Markdown

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@NickElliot NickElliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the tests are failing with the following:

        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 63, in resource "google_vertex_ai_reasoning_engine" "reasoning_engine":
          63:     traffic_split_always_latest = {}
        
        An argument named "traffic_split_always_latest" is not expected here. Did you
        mean to define a block of type "traffic_split_always_latest"?
    panic.go:694: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unsupported argument
        
          on terraform_plugin_test.tf line 63, in resource "google_vertex_ai_reasoning_engine" "reasoning_engine":
          63:     traffic_split_always_latest = {}
        
        An argument named "traffic_split_always_latest" is not expected here. Did you
        mean to define a block of type "traffic_split_always_latest"?```

Could you make sure there is full test coverage for these added fields as well?

@github-actions

Copy link
Copy Markdown

@guvenenb, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 18, 2026
@modular-magician

modular-magician commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b60b8b0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 160 insertions(+)
google-beta provider View Diff 5 files changed, 1013 insertions(+), 10 deletions(-)
terraform-google-conversion View Diff 1 file changed, 376 insertions(+)
Open in Cloud Shell View Diff 2 files changed, 13 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_reasoning_engine (24 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_reasoning_engine" "primary" {
  context_spec {
    example_store_config {
      similarity_search_config {
        embedding_model = # value needed
      }
    }
  }
  spec {
    agent_card = # value needed
    deployment_spec {
      agent_gateway_config {
        agent_to_anywhere_config {
          agent_gateway = # value needed
        }
        client_to_agent_config {
          agent_gateway = # value needed
        }
      }
      keep_alive_probe {
        http_get {
          path = # value needed
          port = # value needed
        }
        max_seconds = # value needed
      }
    }
    example_store = # value needed
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
99 92 4 3
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineBasicExample
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineBasicExample
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate
❌ Error · Log - TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@guvenenb, @NickElliot VCR tests complete for b60b8b0!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 18, 2026
guvenenb added 2 commits June 18, 2026 20:47
… IAM panic

- Updated vertex_ai_reasoning_engine_full example to use traffic_split_always_latest instead of traffic_split_manual, resolving perpetual plan mismatch.
- Fixed nil pointer dereference panic in bootstrap_iam_test_utils.go when project retrieval fails.

TAG=agy
CONV=7bc9c29e-b75e-4607-b4db-43cea40a3c95
@guvenenb guvenenb closed this Jun 19, 2026
@guvenenb guvenenb reopened this Jun 19, 2026
@guvenenb guvenenb closed this Jun 19, 2026
@guvenenb guvenenb reopened this Jun 19, 2026
@guvenenb guvenenb closed this Jun 19, 2026
@guvenenb guvenenb reopened this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/aiplatform-agent-engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants