api differences are resolved.#17719
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi @NickElliot, can you look and review this PR, it is quite urgent, I would be very grateful if you could take the time to look at it. Thank you a lot! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a5e85dc: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_reasoning_engine" "primary" {
context_spec {
example_store_config {
similarity_search_config {
embedding_model = # value needed
}
}
}
spec {
agent_card = # value needed
deployment_spec {
agent_gateway_config {
agent_to_anywhere_config {
agent_gateway = # value needed
}
client_to_agent_config {
agent_gateway = # value needed
}
}
keep_alive_probe {
http_get {
path = # value needed
port = # value needed
}
max_seconds = # value needed
}
}
example_store = # value needed
}
traffic_config {
traffic_split_manual {
targets {
percent = # value needed
runtime_revision_name = # value needed
}
}
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @guvenenb, @NickElliot VCR tests complete for a5e85dc! |
|
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label |
NickElliot
left a comment
There was a problem hiding this comment.
Hi, the tests are failing with the following:
Error: Unsupported argument
on terraform_plugin_test.tf line 63, in resource "google_vertex_ai_reasoning_engine" "reasoning_engine":
63: traffic_split_always_latest = {}
An argument named "traffic_split_always_latest" is not expected here. Did you
mean to define a block of type "traffic_split_always_latest"?
panic.go:694: Error running post-test destroy, there may be dangling resources: exit status 1
Error: Unsupported argument
on terraform_plugin_test.tf line 63, in resource "google_vertex_ai_reasoning_engine" "reasoning_engine":
63: traffic_split_always_latest = {}
An argument named "traffic_split_always_latest" is not expected here. Did you
mean to define a block of type "traffic_split_always_latest"?```
Could you make sure there is full test coverage for these added fields as well?
|
@guvenenb, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b60b8b0: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_reasoning_engine" "primary" {
context_spec {
example_store_config {
similarity_search_config {
embedding_model = # value needed
}
}
}
spec {
agent_card = # value needed
deployment_spec {
agent_gateway_config {
agent_to_anywhere_config {
agent_gateway = # value needed
}
client_to_agent_config {
agent_gateway = # value needed
}
}
keep_alive_probe {
http_get {
path = # value needed
port = # value needed
}
max_seconds = # value needed
}
}
example_store = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @guvenenb, @NickElliot VCR tests complete for b60b8b0! |
… IAM panic - Updated vertex_ai_reasoning_engine_full example to use traffic_split_always_latest instead of traffic_split_manual, resolving perpetual plan mismatch. - Fixed nil pointer dereference panic in bootstrap_iam_test_utils.go when project retrieval fails. TAG=agy CONV=7bc9c29e-b75e-4607-b4db-43cea40a3c95

This Pull Request implements API parity for the google_vertex_ai_reasoning_engine resource by introducing several new configuration fields. At the root level, it adds the output-only url
│ field and traffic_config to support traffic splitting configurations (both manual and always-latest). Within the deployment specifications, it introduces agent_server_mode ,
│ agent_gateway_config (for secure inbound and outbound traffic via Google-managed gateways), and keep_alive_probe . Finally, it updates the agent's spec with agent_card and example_store
│ support, and adds example_store_config to the context_spec for similarity search configurations. All these fields are introduced as beta features.