feat: Add GKE CustomNodeInit support by zicongmei · Pull Request #17743 · GoogleCloudPlatform/magic-modules

zicongmei · 2026-05-26T23:59:32Z

Adds support for GKE custom node initialization scripts configuration in LinuxNodeConfig. This includes:

Adding custom_node_init schema to linux_node_config block.
Implementing expander and flattener helpers for CustomNodeInit and InitScript.
Adding TestAccContainerNodePool_withCustomNodeInit integration test template.

This supports both GCS URI (with specific generation) and GCP Secret Manager secret URI configurations.

TAG=agy
CONV=753c21e2-16d4-4cc3-9aef-bf8b374d142c

Release Note Template for Downstream PRs (will be copied)

container: added `custom_node_init` configuration block to `node_config` (supporting Cloud Storage and Secret Manager) for both `google_container_cluster` and `google_container_node_pool` resources.

Adds support for GKE custom node initialization scripts configuration in LinuxNodeConfig. This includes: - Adding custom_node_init schema to linux_node_config block. - Implementing expander and flattener helpers for CustomNodeInit and InitScript. - Adding TestAccContainerNodePool_withCustomNodeInit integration test template. This supports both GCS URI (with specific generation) and GCP Secret Manager secret URI configurations. TAG=agy CONV=753c21e2-16d4-4cc3-9aef-bf8b374d142c

github-actions · 2026-05-26T23:59:57Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-05-27T00:10:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 46d0291:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2 files changed, 185 insertions(+)
`google-beta` provider	View Diff	2 files changed, 185 insertions(+)
`terraform-google-conversion`	View Diff	1 file changed, 3 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (553 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      custom_node_init {
        init_script {
          gcp_secret_manager_secret_uri = # value needed
          gcs_generation                = # value needed
          gcs_uri                       = # value needed
        }
      }
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        custom_node_init {
          init_script {
            gcp_secret_manager_secret_uri = # value needed
            gcs_generation                = # value needed
            gcs_uri                       = # value needed
          }
        }
      }
    }
  }
}

Resource: google_container_node_pool (122 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      custom_node_init {
        init_script {
          gcp_secret_manager_secret_uri = # value needed
          gcs_generation                = # value needed
        }
      }
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_config.linux_node_config.custom_node_init node_config.linux_node_config.custom_node_init.init_script node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_config.linux_node_config.custom_node_init.init_script.gcs_uri node_pool.node_config.linux_node_config.custom_node_init node_pool.node_config.linux_node_config.custom_node_init.init_script node_pool.node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_uri]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.linux_node_config.custom_node_init node_config.linux_node_config.custom_node_init.init_script node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_config.linux_node_config.custom_node_init.init_script.gcs_uri]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
294	275	16	3

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withCustomNodeInit
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInit
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@zicongmei, @trodge VCR tests complete for 46d0291!

modular-magician · 2026-05-27T16:06:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c22df28:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	4 files changed, 475 insertions(+)
`google-beta` provider	View Diff	4 files changed, 475 insertions(+)
`terraform-google-conversion`	View Diff	2 files changed, 12 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_pool.node_config.linux_node_config.custom_node_init node_pool.node_config.linux_node_config.custom_node_init.init_script node_pool.node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_uri]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.linux_node_config.custom_node_init node_config.linux_node_config.custom_node_init.init_script node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_config.linux_node_config.custom_node_init.init_script.gcs_uri]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
297	275	16	6

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_withCustomNodeInitGcs
TestAccContainerCluster_withCustomNodeInitSecret
TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withCustomNodeInit
TestAccContainerNodePool_withCustomNodeInitSecret
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitGcs
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInit
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@zicongmei, @trodge VCR tests complete for c22df28!

modular-magician · 2026-05-27T16:50:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 14d8fc8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	5 files changed, 495 insertions(+)
`google-beta` provider	View Diff	5 files changed, 495 insertions(+)
`terraform-google-conversion`	View Diff	2 files changed, 12 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_pool.node_config.linux_node_config.custom_node_init node_pool.node_config.linux_node_config.custom_node_init.init_script node_pool.node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_uri]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.linux_node_config.custom_node_init node_config.linux_node_config.custom_node_init.init_script node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_config.linux_node_config.custom_node_init.init_script.gcs_uri]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
297	275	16	6

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_withCustomNodeInitGcs
TestAccContainerCluster_withCustomNodeInitSecret
TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withCustomNodeInit
TestAccContainerNodePool_withCustomNodeInitSecret
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitGcs
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInit
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@zicongmei, @trodge VCR tests complete for 14d8fc8!

trodge · 2026-05-27T18:20:57Z

Current test failure:

2026-05-27T17:04:07.566Z [ERROR] sdk.proto: Response contains error diagnostic: tf_provider_addr=registry.terraform.io/hashicorp/google tf_proto_version=5.11 tf_rpc=ApplyResourceChange tf_req_id=59e89b7e-2f9b-e52e-0d97-a1383c56cd17 tf_resource_type=google_container_cluster diagnostic_detail="" diagnostic_severity=ERROR
  diagnostic_summary=
  | googleapi: Error 400: It's invalid to specify both cluster.node_config and a node pool. Please only provide a node pool.
  | Details:
  | [
  |   {
  |     "@type": "type.googleapis.com/google.rpc.RequestInfo",
  |     "requestId": "0xb3daf0406788dc29"
  |   }
  | ]
  | , badRequest

trodge

See above comment.

modular-magician · 2026-05-27T21:07:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a7e8cd8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	5 files changed, 582 insertions(+)
`google-beta` provider	View Diff	5 files changed, 582 insertions(+)
`terraform-google-conversion`	View Diff	2 files changed, 15 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_pool.node_config.linux_node_config.custom_node_init node_pool.node_config.linux_node_config.custom_node_init.init_script node_pool.node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_uri]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.linux_node_config.custom_node_init node_config.linux_node_config.custom_node_init.init_script node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_config.linux_node_config.custom_node_init.init_script.gcs_uri]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
298	275	16	7

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_withCustomNodeInitGcs
TestAccContainerCluster_withCustomNodeInitInline
TestAccContainerCluster_withCustomNodeInitSecret
TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withCustomNodeInit
TestAccContainerNodePool_withCustomNodeInitSecret
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitGcs
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitInline
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInit
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@zicongmei, @trodge VCR tests complete for a7e8cd8!

Moves GKE Cluster and GKE Node Pool node_config stubs and custom_node_init nested blocks from the bottom sections (User Project Overrides / Import) up to the correct locations under the Argument Reference section. This fixes the document layout semantics for human readers while maintaining the paths expected by the static doc-validator tool. TAG=agy CONV=753c21e2-16d4-4cc3-9aef-bf8b374d142c

modular-magician · 2026-05-29T17:00:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e6a9966:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	5 files changed, 596 insertions(+), 2 deletions(-)
`google-beta` provider	View Diff	5 files changed, 596 insertions(+), 2 deletions(-)
`terraform-google-conversion`	View Diff	2 files changed, 15 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_pool.node_config.linux_node_config.custom_node_init node_pool.node_config.linux_node_config.custom_node_init.init_script node_pool.node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_uri]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.linux_node_config.custom_node_init node_config.linux_node_config.custom_node_init.init_script node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_config.linux_node_config.custom_node_init.init_script.gcs_uri]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
298	275	16	7

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_withCustomNodeInitGcs
TestAccContainerCluster_withCustomNodeInitInline
TestAccContainerCluster_withCustomNodeInitSecret
TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withCustomNodeInit
TestAccContainerNodePool_withCustomNodeInitSecret
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerNodePool_withCustomNodeInit
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitGcs
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitInline
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@zicongmei, @trodge VCR tests complete for e6a9966!

modular-magician · 2026-05-29T17:09:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 37de94b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	5 files changed, 596 insertions(+), 2 deletions(-)
`google-beta` provider	View Diff	5 files changed, 596 insertions(+), 2 deletions(-)
`terraform-google-conversion`	View Diff	2 files changed, 15 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
298	275	16	7

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_withCustomNodeInitGcs
TestAccContainerCluster_withCustomNodeInitInline
TestAccContainerCluster_withCustomNodeInitSecret
TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withCustomNodeInit
TestAccContainerNodePool_withCustomNodeInitSecret
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerNodePool_withCustomNodeInit
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitGcs
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitInline
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@zicongmei, @trodge VCR tests complete for 37de94b!

…edirects Reverts GKE Cluster and GKE Node Pool path stubs and parameter link redirect updates. This leaves both documents in a clean Path A state (similar to GKE containerd_config): - GKE Custom Node Init is fully documented under GKE Cluster's linux_node_config. - GKE Node Pool document continues to rely on the clean global redirect to GKE Cluster for its node_config schema, without maintaining duplicate stubs or parser-specific helper anchors. TAG=agy CONV=753c21e2-16d4-4cc3-9aef-bf8b374d142c

modular-magician · 2026-05-29T17:20:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 02715d5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	4 files changed, 562 insertions(+)
`google-beta` provider	View Diff	4 files changed, 562 insertions(+)
`terraform-google-conversion`	View Diff	2 files changed, 15 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_pool.node_config.linux_node_config.custom_node_init node_pool.node_config.linux_node_config.custom_node_init.init_script node_pool.node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_uri]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.linux_node_config.custom_node_init node_config.linux_node_config.custom_node_init.init_script node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_config.linux_node_config.custom_node_init.init_script.gcs_uri]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
298	275	16	7

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_withCustomNodeInitGcs
TestAccContainerCluster_withCustomNodeInitInline
TestAccContainerCluster_withCustomNodeInitSecret
TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withCustomNodeInit
TestAccContainerNodePool_withCustomNodeInitSecret
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerNodePool_withCustomNodeInit
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitGcs
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitInline
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@zicongmei, @trodge VCR tests complete for 02715d5!

Declares the new CustomNodeInit leaf fields under GKE Cluster and GKE Node Pool resource metadata configs. This fixes the static downstream validation check (TestValidateResourceMetadata in allservices package) which ensures all Go schema definitions have matching metadata mappings. TAG=agy CONV=753c21e2-16d4-4cc3-9aef-bf8b374d142c

modular-magician · 2026-05-29T17:35:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 48a38b4:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	6 files changed, 577 insertions(+)
`google-beta` provider	View Diff	6 files changed, 577 insertions(+)
`terraform-google-conversion`	View Diff	2 files changed, 15 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

google_container_cluster
- Expected Document Path: /website/docs/r/container_cluster.html.markdown
- Fields: [node_pool.node_config.linux_node_config.custom_node_init node_pool.node_config.linux_node_config.custom_node_init.init_script node_pool.node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_pool.node_config.linux_node_config.custom_node_init.init_script.gcs_uri]
google_container_node_pool
- Expected Document Path: /website/docs/r/container_node_pool.html.markdown
- Fields: [node_config.linux_node_config.custom_node_init node_config.linux_node_config.custom_node_init.init_script node_config.linux_node_config.custom_node_init.init_script.gcp_secret_manager_secret_uri node_config.linux_node_config.custom_node_init.init_script.gcs_generation node_config.linux_node_config.custom_node_init.init_script.gcs_uri]

Test report

Analytics

Total Tests	Passed	Skipped	Affected
298	275	16	7

Affected Service Packages

container

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccContainerCluster_withCustomNodeInitGcs
TestAccContainerCluster_withCustomNodeInitInline
TestAccContainerCluster_withCustomNodeInitSecret
TestAccContainerCluster_withLoggingConfig
TestAccContainerNodePool_withCustomNodeInit
TestAccContainerNodePool_withCustomNodeInitSecret
TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerNodePool_withCustomNodeInit
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitGcs
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitInline
❌ Error · Log	-	TestAccContainerCluster_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerCluster_withLoggingConfig
❌ Error · Log	-	TestAccContainerNodePool_withCustomNodeInitSecret
❌ Error · Log	-	TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@zicongmei, @trodge VCR tests complete for 48a38b4!

github-actions Bot requested a review from trodge May 26, 2026 23:59

modular-magician added the service/container label May 27, 2026

Add test and doc

c22df28

update nodepool doc

14d8fc8

trodge requested changes May 27, 2026

View reviewed changes

fix test

a7e8cd8

github-actions Bot requested a review from trodge May 27, 2026 20:58

zicongmei added 2 commits May 29, 2026 09:50

Fix doc reference

e6a9966

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add GKE CustomNodeInit support#17743

feat: Add GKE CustomNodeInit support#17743
zicongmei wants to merge 8 commits into
GoogleCloudPlatform:mainfrom
zicongmei:main

zicongmei commented May 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

modular-magician commented May 27, 2026 •

edited

Loading

Uh oh!

modular-magician commented May 27, 2026 •

edited

Loading

Uh oh!

modular-magician commented May 27, 2026 •

edited

Loading

Uh oh!

trodge commented May 27, 2026

Uh oh!

trodge left a comment

Uh oh!

modular-magician commented May 27, 2026 •

edited

Loading

Uh oh!

modular-magician commented May 29, 2026 •

edited

Loading

Uh oh!

modular-magician commented May 29, 2026 •

edited

Loading

Uh oh!

modular-magician commented May 29, 2026 •

edited

Loading

Uh oh!

modular-magician commented May 29, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zicongmei commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

modular-magician commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing test report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

trodge commented May 27, 2026

Uh oh!

trodge left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

modular-magician commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

zicongmei commented May 26, 2026 •

edited

Loading

modular-magician commented May 27, 2026 •

edited

Loading

modular-magician commented May 27, 2026 •

edited

Loading

modular-magician commented May 27, 2026 •

edited

Loading

modular-magician commented May 27, 2026 •

edited

Loading

modular-magician commented May 29, 2026 •

edited

Loading

modular-magician commented May 29, 2026 •

edited

Loading

modular-magician commented May 29, 2026 •

edited

Loading

modular-magician commented May 29, 2026 •

edited

Loading