feat(vertexai): add google_vertex_ai_online_evaluator resource#17944
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
- Rename location parameter to region for consistency. - Update format description in name property to use region. - Add timeouts (insert/update: 20m, delete: 60m) to OnlineEvaluator. - Specify OpAsync type for async operations. - Clean up comments in custom flatten template. TAG=agy CONV=5308268d-2e95-4a0c-8ce0-cdac27b8c645
- Use custom flattener for name to extract short ID. - Update self_link to use full path template with short name. - Update basic example to use region instead of location. TAG=agy CONV=5308268d-2e95-4a0c-8ce0-cdac27b8c645
… metrics
- Add a simple google_vertex_ai_reasoning_engine resource to the basic example to make it self-contained and runnable.
- Reference the reasoning engine ID in the evaluator's agent_resource.
- Add predefined metrics for hallucination, final response quality, and tool use quality to enrich the example.
TAG=agy
CONV=56524cca-e5c6-4a4d-bf34-390d5c1e5c74
- Add TODO comment to support structured metric config in the future instead of JSON string.
- Update description of the metric field to list suggested predefined metric names (including multi-turn metrics) for user reference.
TAG=agy
CONV=56524cca-e5c6-4a4d-bf34-390d5c1e5c74
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label |
roaks3
left a comment
There was a problem hiding this comment.
Overall looks good, but left a few comments, mainly to align with common practices
roaks3
left a comment
There was a problem hiding this comment.
LGTM, just one minor comment on the tests
… in online evaluator tests
- Added 'tf-test-' prefix to 'display_name' fields in online evaluator test configs to allow sweeper cleanup.
- Added 'provider = google-beta' to resources in online evaluator tests to fix inconsistent dependency lock file error.
TAG=agy
CONV=7bc9c29e-b75e-4607-b4db-43cea40a3c95
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1c349d6: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_online_evaluator" "primary" {
cloud_observability {
log_view = # value needed
trace_view = # value needed
}
metric_sources {
metric_resource_name = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
|
update test looks like a field is trying to be updated that shouldn't? And the basic example probably needs either |
- Add google_vertex_ai_online_evaluator to enrolled_teams.yml for service labeler. - Add TestAccVertexAIOnlineEvaluator_full to cover cloud_observability and metric_sources. - Implement helper to dynamically create/delete EvaluationMetric dependency in the test. TAG=agy CONV=7205c9b4-543f-4e5a-b743-93db32f7121c
- Mark openTelemetry field as ignore_read: true to prevent perpetual drift. - Mark metricSources as immutable: true to align with backend API restrictions. - Add provider = google-beta to basic example config. - Add cloud_observability.0.open_telemetry to ImportStateVerifyIgnore in update test. - Remove TestAccVertexAIOnlineEvaluator_full to avoid VCR recording issues and dependencies. TAG=agy CONV=af1d212f-1300-4b9f-ade0-e28655f4ecc7
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5a24c63: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_online_evaluator" "primary" {
cloud_observability {
log_view = # value needed
trace_view = # value needed
}
metric_sources {
metric_resource_name = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. |
- Add immutable: true to "metric" and "metricResourceName" fields under metric_sources. - This ensures changing these fields forces resource replacement, aligning with API behavior. TAG=agy CONV=e140dd26-45cc-49c9-b656-0a71375a4aa7
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a5a761a: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_vertex_ai_online_evaluator" "primary" {
cloud_observability {
log_view = # value needed
trace_view = # value needed
}
metric_sources {
metric_resource_name = # value needed
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log |
7b2c6fe
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.