FEAT: add support to wildfire fields on google_network_security resources#17981
FEAT: add support to wildfire fields on google_network_security resources#17981victorsantos-cit wants to merge 14 commits into
Conversation
Added a Terraform template for a basic network security profile with components including network, subnetwork, compute address, security policies, and authorization policies.
Added sample configurations for wildfire security profiles and updated parameters for wildfire analysis.
Added WildFire settings including analysis options and timeout actions.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Updated the location to 'us-central1-a' and changed the wildfire region to 'UNITED_STATES'.
Exclude test for firewall endpoint creation due to duration.
Add acceptance tests for wildfire settings in firewall endpoints.
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6399f55: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_security_security_profile" "primary" {
wildfire_analysis_profile {
wildfire_inline_cloud_analysis_rules {
action = # value needed
custom_file_types {
file_types = # value needed
}
direction = # value needed
file_selection_mode = # value needed
}
wildfire_submission_rules {
custom_file_types {
file_types = # value needed
}
direction = # value needed
file_selection_mode = # value needed
}
}
}
Test reportImportant Manual Verification Required VCR cannot automatically execute the following tests added in this PR. Please verify them manually: 🔴 TestAccNetworkSecurityFirewallEndpoints_wildfire Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @victorsantos-cit, @NickElliot VCR tests complete for 6399f55! |
|
All ? |
|
or just to TestAccNetworkSecurityFirewallEndpoints_wildfire |
NickElliot
left a comment
There was a problem hiding this comment.
yeah TestAccNetworkSecurityFirewallEndpoints_wildfire is fine
|
ok, just a second |
Hello Folks, this PR is to create a support to wildfire field on network security resources
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.