Skip to content

FEAT: add support to wildfire fields on google_network_security resources#17981

Open
victorsantos-cit wants to merge 14 commits into
GoogleCloudPlatform:mainfrom
victorsantos-cit:feat/add-support-to-wildfire-fields
Open

FEAT: add support to wildfire fields on google_network_security resources#17981
victorsantos-cit wants to merge 14 commits into
GoogleCloudPlatform:mainfrom
victorsantos-cit:feat/add-support-to-wildfire-fields

Conversation

@victorsantos-cit

Copy link
Copy Markdown
Contributor

Hello Folks, this PR is to create a support to wildfire field on network security resources

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `wildfire_settings` field on `google_network_security_firewall_endpoint` resource
compute: added `wildfire_analysis_profile` field on `google_network_security_security_profile` and `google_network_security_security_profile_group` resource

Added a Terraform template for a basic network security profile with components including network, subnetwork, compute address, security policies, and authorization policies.
Added sample configurations for wildfire security profiles and updated parameters for wildfire analysis.
Added WildFire settings including analysis options and timeout actions.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 16, 2026
@github-actions github-actions Bot requested a review from NickElliot June 16, 2026 21:14
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Updated the location to 'us-central1-a' and changed the wildfire region to 'UNITED_STATES'.
Exclude test for firewall endpoint creation due to duration.
Add acceptance tests for wildfire settings in firewall endpoints.
@victorsantos-cit

Copy link
Copy Markdown
Contributor Author

/gcbrun

@modular-magician modular-magician added service/network-security-distributed-firewall and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 18, 2026
@modular-magician

modular-magician commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6399f55:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 429 insertions(+), 3 deletions(-)
google-beta provider View Diff 12 files changed, 1450 insertions(+), 3 deletions(-)
terraform-google-conversion View Diff 5 files changed, 327 insertions(+), 2 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_security_profile (40 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_security_profile" "primary" {
  wildfire_analysis_profile {
    wildfire_inline_cloud_analysis_rules {
      action = # value needed
      custom_file_types {
        file_types = # value needed
      }
      direction           = # value needed
      file_selection_mode = # value needed
    }
    wildfire_submission_rules {
      custom_file_types {
        file_types = # value needed
      }
      direction           = # value needed
      file_selection_mode = # value needed
    }
  }
}

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccNetworkSecurityFirewallEndpoints_wildfire

Analytics

Total Tests Passed Skipped Affected
86 76 8 2
Affected Service Packages
  • networksecurity

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkSecuritySecurityProfileGroup_securityProfileGroupWildfireBasicExample
  • TestAccNetworkSecuritySecurityProfile_networkSecurityProfileWildfireBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccNetworkSecuritySecurityProfileGroup_securityProfileGroupWildfireBasicExample
✅ Log TestAccNetworkSecuritySecurityProfile_networkSecurityProfileWildfireBasicExample

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@victorsantos-cit, @NickElliot VCR tests complete for 6399f55!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 18, 2026

@NickElliot NickElliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you share a debug log for a manual run of the added tests?

@victorsantos-cit

Copy link
Copy Markdown
Contributor Author

All ?

@victorsantos-cit

Copy link
Copy Markdown
Contributor Author

or just to TestAccNetworkSecurityFirewallEndpoints_wildfire

@github-actions github-actions Bot requested a review from NickElliot June 18, 2026 19:54

@NickElliot NickElliot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah TestAccNetworkSecurityFirewallEndpoints_wildfire is fine

@victorsantos-cit

Copy link
Copy Markdown
Contributor Author

ok, just a second

@github-actions github-actions Bot requested a review from NickElliot June 18, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/network-security-distributed-firewall

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants