Skip to content

network_services: add forwardAttributes field for service extensions#18003

Open
translucens wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
translucens:add-serviceextensions-forwardattributes
Open

network_services: add forwardAttributes field for service extensions#18003
translucens wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
translucens:add-serviceextensions-forwardattributes

Conversation

@translucens

@translucens translucens commented Jun 18, 2026

Copy link
Copy Markdown
Member
networkservices: added `forward_attributes` field to `google_network_services_lb_edge_extension`, `google_network_services_lb_route_extension`, and `google_network_services_lb_traffic_extension` resources

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a41eb8f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 11 files changed, 135 insertions(+), 13 deletions(-)
google-beta provider View Diff 11 files changed, 135 insertions(+), 13 deletions(-)
terraform-google-conversion View Diff 3 files changed, 33 insertions(+)
Open in Cloud Shell View Diff 2 files changed, 2 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_edge_extension (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_edge_extension" "primary" {
  extension_chains {
    extensions {
      forward_attributes = # value needed
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
101 97 2 2
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample
  • TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample
✅ Log TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@translucens, @malhotrasagar2212 VCR tests complete for a41eb8f!

@malhotrasagar2212 malhotrasagar2212 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the missing test report and add test coverage for google_network_services_lb_edge_extension.extension_chains.extensions.forward_attributes

Comment thread mmv1/products/networkservices/LbEdgeExtension.yaml
@malhotrasagar2212

Copy link
Copy Markdown
Collaborator

Please add update test coverage for the forward_attributes. Thanks

@modular-magician

modular-magician commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b23e911:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 141 insertions(+), 13 deletions(-)
google-beta provider View Diff 12 files changed, 141 insertions(+), 13 deletions(-)
terraform-google-conversion View Diff 3 files changed, 33 insertions(+)
Open in Cloud Shell View Diff 2 files changed, 2 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
101 98 2 1
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccNetworkServicesLbEdgeExtension_networkServicesLbEdgeExtensionBasicUpdate

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@translucens, @malhotrasagar2212 VCR tests complete for b23e911!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants