network_services: add forwardAttributes field for service extensions#18003
network_services: add forwardAttributes field for service extensions#18003translucens wants to merge 3 commits into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a41eb8f: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_services_lb_edge_extension" "primary" {
extension_chains {
extensions {
forward_attributes = # value needed
}
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @translucens, @malhotrasagar2212 VCR tests complete for a41eb8f! |
malhotrasagar2212
left a comment
There was a problem hiding this comment.
Please check the missing test report and add test coverage for google_network_services_lb_edge_extension.extension_chains.extensions.forward_attributes
|
Please add update test coverage for the |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b23e911: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @translucens, @malhotrasagar2212 VCR tests complete for b23e911! |
Uh oh!
There was an error while loading. Please reload this page.