Skip to content

tgc-revival: Ignore shareSettings in compute reservation since it is missing in CAI#18008

Merged
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
zli82016:fix-compute-reservation-sharing
Jun 18, 2026
Merged

tgc-revival: Ignore shareSettings in compute reservation since it is missing in CAI#18008
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
zli82016:fix-compute-reservation-sharing

Conversation

@zli82016

@zli82016 zli82016 commented Jun 18, 2026

Copy link
Copy Markdown
Member

Resolves integration test failures for google_compute_reservation due to share_settings.share_type being missing in CAI asset payload. Marks the property as is_missing_in_cai: true.

--- FAIL: TestAccComputeReservation/TestAccComputeReservation_sharedReservationBasicExample/step1 (0.22s)
           assert_test_files.go:138: TestAccComputeReservation_sharedReservationBasicExample_step1: Failed after 5 attempts. First real error: retryable: missing fields: [share_settings.share_type]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a63bd7f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 1 file changed, 1 insertion(+)

@zli82016 zli82016 requested a review from c2thorn June 18, 2026 16:45
@zli82016 zli82016 changed the title Fix: Ignore shareSettings in compute reservation since it is missing in CAI tgc-revival: Ignore shareSettings in compute reservation since it is missing in CAI Jun 18, 2026
@zli82016 zli82016 added this pull request to the merge queue Jun 18, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 2526a00 Jun 18, 2026
30 of 32 checks passed
@zli82016 zli82016 deleted the fix-compute-reservation-sharing branch June 18, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants