Remove tpu configs from AOT test and update HybridSim test name #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondzouu
requested review from
tonyjohnchen,
gobbleturk,
shralex,
RissyRan,
jiangjy1982,
richardsliu,
yixinshi,
allenwang28,
zpcore,
ManfeiBai,
ortibazar,
parambole,
vipannalla,
crankshaw-google and
polydier1
as code owners
raymondzouu
force-pushed
the
raymondzou-aot-hybridsim
branch
from
2b1eca7 to
f632913
Compare
shralex
reviewed
Jan 14, 2025
| @@ -36,72 +36,10 @@ | |||
| catchup=False, | |||
There was a problem hiding this comment.
If the only tests remaining are gpu, can we have the name of the dag reflect that ?
shralex
reviewed
Jan 14, 2025
| test_owner=test_owner.RAYMOND_Z, | ||
| ).run_with_quarantine(quarantine_task_group) | ||
|
|
||
| maxtext_v5p_configs_test = gke_config.get_gke_config( |
There was a problem hiding this comment.
Is v5p included in the hybridsim dag ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove tpu configs from AOT test since they are already covered by the HybridSim test. Update HybridSim test name to reduce confusion.
Tests
N/A
Checklist
Before submitting this PR, please make sure (put X in square brackets):