Add regression test for Llama3.1 70B GCSFuse NeMo recipe in main branch #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lepan-google
requested review from
Doris26,
cneel8986,
crankshaw-google,
gunjanj007,
polydier1,
stingram,
utkarshsharma1,
wang2yn84 and
zshu188
as code owners
gunjanj007
approved these changes
May 19, 2025
mkmg
reviewed
May 19, 2025
| cmds = ( | ||
| "python3 " | ||
| f"{recipe_repo_root}/src/utils/checkpointing_metrics" | ||
| f"(cd {recipe_repo_root} && git checkout storage-next " |
Collaborator
There was a problem hiding this comment.
Do we want to pass the branch here so we can use the main branch when possible?
Collaborator
Author
There was a problem hiding this comment.
Currently, only the log scraper in the storage-next branch has the feature to upload the final results to BQ tables. The log scraper in main branch only calculates the results and prints it out to the user. So currently, we need to go to the storage-next branch for metrics calculation and uploading even we run with the main branch recipe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add regression test for Llama3.1 70B GCSFuse NeMo recipe in main branch.
Ran tests locally
A3mega Llama3.1 70B GCSFuse NeMo main branch recipe: link
A3mega Llama3.1 70B GCSFuse NeMo storage-next branch recipie: link
A3mega llama3.1 70B NeMo main branch recipe (original synthetic data recipe): link