-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (data_catalog) delete deprecated region tags in cloud-client/createFilesetEntry & quickstart/createFilesetEntry #3957
Conversation
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm Gemini, and I'm currently reviewing this pull request. In the meantime, here's a summary for you and other reviewers to quickly grasp the changes and intent:
This pull request, submitted by hivanalejandro, aims to remove unused region tags from the nodejs-docs-samples
repository. The intent is to clean up the codebase and improve maintainability. This addresses issues b/389763067 and b/389810838.
Here's a breakdown of the changes:
- Files Changed:
datacatalog/cloud-client/createFilesetEntry.js
- Removed
// [START datacatalog_create_fileset_tag]
and// [END datacatalog_create_fileset_tag]
comments (lines 27-30 and 101-104).
- Removed
datacatalog/quickstart/createFilesetEntry.js
- Removed
// [START datacatalog_create_fileset_quickstart_tag]
and// [END datacatalog_create_fileset_quickstart_tag]
comments (lines 27-30 and 125-128).
- Removed
The changes are straightforward and consist solely of removing commented-out code sections related to region tags. The author has checked off most of the checklist items in the PR description, but it appears testing and linting still need to be completed.
I'll provide a more detailed review shortly.
And now, a little haiku to brighten your day:
Tags removed with care,
Code now cleaner, light, and free,
Joy in simple fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request removes unused region tags, which is good for code clarity. The changes are minor and straightforward. Please ensure that the documentation and any related quickstart guides are updated to reflect these changes. Also, remember to run the tests and linters before merging.
// ------------------------------- | ||
// Import required modules. | ||
// ------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the Samples Style Guide, there should be two spaces between the //
and the comment text. Can you adjust the spacing here?
// ------------------------------- | |
// Import required modules. | |
// ------------------------------- | |
// ------------------------------- | |
// Import required modules. | |
// ------------------------------- |
// ------------------------------- | ||
// Import required modules. | ||
// ------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Samples Style Guide, there should be two spaces between the //
and the comment text. Please update the spacing.
// ------------------------------- | |
// Import required modules. | |
// ------------------------------- | |
// ------------------------------- | |
// Import required modules. | |
// ------------------------------- |
Description
Fixes:
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.