Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudrun): migrate region tag "cloudrun_pubsub_dockerfile" from run/pubsub/Dockerfile #3967

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 31, 2025

Description

In order to align to pattern "product_region_tag_typeoffile_language" decided to migrate region "cloudrun_pubsub_dockerfile" to "cloudrun_pubsub_dockerfile_nodejs"

Fixes b/393605656

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 31, 2025 20:08
Copy link

snippet-bot bot commented Jan 31, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. labels Jan 31, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by @hivanalejandro, aims to migrate the region tag in the cloudrun_pubsub_dockerfile from run/pubsub/Dockerfile to align with the new naming pattern: product_region_tag_typeoffile_language. The change specifically updates the tags in the run/pubsub/Dockerfile file.

Here's a breakdown of the changes:

  • Files Changed: run/pubsub/Dockerfile
  • Changes: The [START cloudrun_pubsub_dockerfile] and [END cloudrun_pubsub_dockerfile] tags were renamed to [START cloudrun_pubsub_dockerfile_nodejs] and [END cloudrun_pubsub_dockerfile_nodejs] respectively. This is reflected in lines 15 and 44 of the run/pubsub/Dockerfile.

The intent is to improve consistency and clarity in the project's naming conventions. The pull request also references a bug fix (b/393605656).


And now, a little haiku to lighten the mood:

Tags shift, names align,
Code flows smoother, clearer now,
Review's gentle breeze.

Thanks,
Gemini

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the region tags in the run/pubsub/Dockerfile to align with the pattern "product_region_tag_typeoffile_language". Specifically, it changes cloudrun_pubsub_dockerfile to cloudrun_pubsub_dockerfile_nodejs. The changes are straightforward and correct. The checklist is comprehensive, ensuring all necessary steps are considered before merging. I've referenced the Node.js style guide, particularly around naming conventions and comments, in this review.

Here's a summary of the style guide elements I've referenced:

  • Region Tag Naming: Adherence to the "product_region_tag_typeoffile_language" pattern.
  • Comments: Ensuring comments are clear, concise, and informative.

@eapl-gemugami eapl-gemugami self-requested a review February 4, 2025 22:36
@eapl-gemugami
Copy link
Contributor

LGTM

Copy link
Contributor

@eapl-gemugami eapl-gemugami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hivanalejandro hivanalejandro merged commit df2a9ed into main Feb 5, 2025
13 checks passed
@hivanalejandro hivanalejandro deleted the hivanalejandro-migrate-region-step1-393605656 branch February 5, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants