Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable new CI for vision package #3968

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Draft

ci: enable new CI for vision package #3968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/config/nodejs-dev.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@
"storage-control",
"texttospeech",
"tpu",
"vision",
"workflows/invoke-private-endpoint"
]
}
1 change: 0 additions & 1 deletion .github/config/nodejs-prod.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@
"talent", // AssertionError: expected '' to match /Job summary/
"translate", // AssertionError: expected 'Languages:\n{ code: \'ab\', name: \'A…' to match /{ code: 'af', name: 'afrikáans' }/
"video-intelligence", // PERMISSION_DENIED: The caller does not have permission
"vision", // REDIS: Error: connect ECONNREFUSED 127.0.0.1:6379
"workflows", // SyntaxError: Cannot use import statement outside a module
"workflows/quickstart" // [ERR_MODULE_NOT_FOUND]: Cannot find package 'ts-node' imported from ...
]
Expand Down
1 change: 1 addition & 0 deletions vision/ci-setup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ci-setup.json file is currently empty. Could you elaborate on its intended purpose and what configuration it will eventually contain? Adding a brief description as a comment within the file would be helpful. Per the style guide, documentation is important, even for configuration files.

{
  // Configuration for CI setup for the vision package.
}

Loading