-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test-isolation env var interpolation #3977
Conversation
…ples into env-var-interpolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
If possible, is there a way we could force a run of testing all the existing packages? It'd be good to make sure the things that have been working still are. (even though we know a few dozen packages need local config)
The scripts directory was matched as a valid package, so I added it to the ignore list. I removed the workflows directory from the ignore list, the rationale being that changes to the GH actions workflows should trigger all jobs. Eventually the scripts directory should live in our tools repo and should be tested over there. Ideally we should also add the "run tests via a comment" functionality at some point, but for now this served as a workaround. |
Ignoring the "experimental" failures, we got |
Update: Node 16 fixed it |
I also made changes to the config files to trigger all tests. |
The |
All non-experimental tests are passing. |
Description
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.