feat: use external cloud-samples-tools repo #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
These test are run in the cloud-samples-tools repo now.
davidcavazos
approved these changes
Feb 19, 2025
| - uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5 | ||
| with: | ||
| go-version: ${{ env.GO_VERSION }} | ||
| - run: go build -o ${{ github.workspace }}/tools ./cmd/... | ||
| working-directory: .github/cloud-samples-tools | ||
| - name: Build Ariwete (from cloud-samples-tools) |
There was a problem hiding this comment.
For now this is good, but I wonder if there's a way to make building the tools part of the reusable workflow, and maybe export the binary into PATH
|
Failures on experimental are expected, so this should be good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cloud-samples-toolshas been moved into it's own repository.This PR:
.github/cloud-samples-toolsrepo