Add a copy of gce_testing.go and dependencies to this repo. #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
approved these changes
Apr 25, 2025
martijnvans
added a commit
to GoogleCloudPlatform/ops-agent
that referenced
this pull request
Apr 28, 2025
GoogleCloudPlatform/opentelemetry-operations-collector#285 is moving gce_testing.go over there. This PR switches this code over to that new location.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically copies gce_testing.go (and some nearby files) into this repo in preparation for using them for a smoke test.
I tested this PR by creating a dummy smoke test along with a go.mod for that smoke test pointing at this PR, and then running the test with
go test. It does compile and run. I'm going to revert the smoke test for now and put it into a follow-up PR so that I can check in a go.mod that doesn't refer to my branch.I am very unclear on whether the module & directory layout I have here is any good, suggestions welcome.