distrogen: Remove unintentional double-generate #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the recent distrogen update PR, this command was changed to run `generator.Generate()` again at the end of the command. This isn't intentional; the move is the final operation. Arguably, the golden tests should be reworked to go through the subcommand codepath rather than directly through the generator.
avilevy18
reviewed
Sep 24, 2025
braydonk
force-pushed
the
fix_distrogen_generate
branch
from
b925311 to
58dc883
Compare
avilevy18
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent distrogen update PR, this command was changed to run
generator.Generate()again at the end of the command. This isn't intentional; the move is the final operation.Arguably, the golden tests should be reworked to go through the subcommand codepath rather than directly through the generator.