Skip to content

Conversation

@braydonk
Copy link
Contributor

This PR adds usage documentation for distrogen. While writing the docs, I found some minor usability issues that I fixed at the same time:

Distro Makefile:

  • COLLECTOR_LD_FLAGS_* variables are specified a bit differently now
  • Removed release.mk and put the local container target into the same Makefile (it was supposed to only be there temporarily)

Project Makefile:

  • Had a bunch of stuff that was supposed to be deleted
  • Removed tidy-all and test-all and renamed the targets to be more clear that it's about doing this in components

| Field | Type | Default | Description |
|-------|------|---------|-------------|
| `name` | string | | The name for the distribution. |
| `display_name` | string | A human-readable name to use for the distribution. It is used in the title for the generated README. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `display_name` | string | A human-readable name to use for the distribution. It is used in the title for the generated README. |
| `display_name` | string | | A human-readable name to use for the distribution. It is used in the title for the generated README. |

| `boringcrypto` | bool | false | Whether to build the binary with [BoringCrypto](https://csrc.nist.gov/CSRC/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp3678.pdf). |
| `collector_cgo` | bool | false | Whether to build the binary with `CGO_ENABLED=1`. This must be true if `boringcrypto` is turned on. |
| `build_container` | enum | `debian` | The base to use for the `Dockerfile.build` container's build layer. Only `debian` and `alpine` are supported right now. |
| `feature_gates` | string[] | | The [`featuregates`](https://github.com/open-telemetry/opentelemetry-collector/tree/main/featuregate) to enable in the Collector. This is leveraged in the default `ENTRYPOINT` of image builds. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should feature gates also be propagated to the systemd and Windows service wrappers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah they should. I will fix that in a followup PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants