-
Notifications
You must be signed in to change notification settings - Fork 38
Distrogen Documentation #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
docs/distrogen/distribution.md
Outdated
| | Field | Type | Default | Description | | ||
| |-------|------|---------|-------------| | ||
| | `name` | string | | The name for the distribution. | | ||
| | `display_name` | string | A human-readable name to use for the distribution. It is used in the title for the generated README. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | `display_name` | string | A human-readable name to use for the distribution. It is used in the title for the generated README. | | |
| | `display_name` | string | | A human-readable name to use for the distribution. It is used in the title for the generated README. | |
| | `boringcrypto` | bool | false | Whether to build the binary with [BoringCrypto](https://csrc.nist.gov/CSRC/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp3678.pdf). | | ||
| | `collector_cgo` | bool | false | Whether to build the binary with `CGO_ENABLED=1`. This must be true if `boringcrypto` is turned on. | | ||
| | `build_container` | enum | `debian` | The base to use for the `Dockerfile.build` container's build layer. Only `debian` and `alpine` are supported right now. | | ||
| | `feature_gates` | string[] | | The [`featuregates`](https://github.com/open-telemetry/opentelemetry-collector/tree/main/featuregate) to enable in the Collector. This is leveraged in the default `ENTRYPOINT` of image builds. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should feature gates also be propagated to the systemd and Windows service wrappers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah they should. I will fix that in a followup PR.
2141f44 to
21465f0
Compare
This PR adds usage documentation for
distrogen. While writing the docs, I found some minor usability issues that I fixed at the same time:Distro Makefile:
COLLECTOR_LD_FLAGS_*variables are specified a bit differently nowrelease.mkand put the local container target into the same Makefile (it was supposed to only be there temporarily)Project Makefile:
tidy-allandtest-alland renamed the targets to be more clear that it's about doing this in components