distrogen: Fix --compare feature
#487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm sure this worked at one point, I don't know when it broke. The compare code had a bit where it tries to get the content of the existing distribution and the temporary generated one, and at some point I made it so it just fetches the existing directory twice meaning it always succeeded. This has been changed to work as intended. As of submission, I expect the PR to fail CI and start passing after my next PR that regenerates GBOC distro folder is merged and rebased here.
jefferbrecht
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure this worked at one point, I don't know when it broke. The compare code had a bit where it tries to get the content of the existing distribution and the temporary generated one, and at some point I made it so it just fetches the existing directory twice meaning it always succeeded. This has been changed to work as intended.
As of submission, I expect the PR to fail CI and start passing after my next PR that regenerates GBOC distro folder is merged and rebased here.